From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 096EEC433EF for ; Sat, 1 Jan 2022 16:14:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F209E6B0071; Sat, 1 Jan 2022 11:14:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ECF156B0073; Sat, 1 Jan 2022 11:14:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE3B66B0074; Sat, 1 Jan 2022 11:14:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0155.hostedemail.com [216.40.44.155]) by kanga.kvack.org (Postfix) with ESMTP id CFDB96B0071 for ; Sat, 1 Jan 2022 11:14:39 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 850391BAF9FD9 for ; Sat, 1 Jan 2022 16:14:39 +0000 (UTC) X-FDA: 78982216278.01.7C56103 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 8A7C8180003 for ; Sat, 1 Jan 2022 16:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=XcgCn4MDqHhoa71szrFMuQC8sZ2VigvhMVV05YZ9l4c=; b=Tvj/rg4WMiKLRm/D3X2JIEY7U5 ZyMJADm1UOZ/rt6uKjmQo+Vi0+q8znzwZWPEABOyuGB7P3NhenOnQguuOOJQjghuDSpUJF0xB5syr 0Tl3O9pQKxaMSc6r0KNTNpukA426QdTj+OR8jKetEeyER+4KC1PwVui5ufbqRu+1dc71K0VosJsf0 urmHgGLMbeKZ/aInNe7yh4udUp03PRTBPJyshiUEWA8udRSMwLl0l4oIF7dIt4naNFJccHPkdxkqU k72NU9K9jod9xFdEVqvdtydnkFK7x9HYlhTNwOkYrU0sTdmGdFTKAbEhSnUTw6DExDYxrwL014Www pXJ8Jgyg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n3h1d-00BOkQ-Sk; Sat, 01 Jan 2022 16:14:33 +0000 Date: Sat, 1 Jan 2022 16:14:33 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 39/48] filemap: Convert filemap_read() to use a folio Message-ID: References: <20211208042256.1923824-1-willy@infradead.org> <20211208042256.1923824-40-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 8A7C8180003 X-Stat-Signature: htt3rfewwfqfmo15wi98qnm998y448jb Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Tvj/rg4W"; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam11 X-HE-Tag: 1641053671-166520 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 23, 2021 at 09:22:02AM +0100, Christoph Hellwig wrote: > On Wed, Dec 08, 2021 at 04:22:47AM +0000, Matthew Wilcox (Oracle) wrote= : > > for (i =3D 0; i < pagevec_count(&pvec); i++) { > > - struct page *page =3D pvec.pages[i]; > > - size_t page_size =3D thp_size(page); > > - size_t offset =3D iocb->ki_pos & (page_size - 1); > > + struct folio *folio =3D page_folio(pvec.pages[i]); > > + size_t fsize =3D folio_size(folio); >=20 > Any reason for fsize vs folio_size? CC mm/filemap.o ../mm/filemap.c: In function =E2=80=98filemap_read=E2=80=99: ../mm/filemap.c:2672:45: error: called object =E2=80=98folio_size=E2=80=99= is not a function or function pointer 2672 | size_t folio_size =3D folio_size(folio); | ^~~~~~~~~~ ../mm/filemap.c:2672:32: note: declared here 2672 | size_t folio_size =3D folio_size(folio); | ^~~~~~~~~~