From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF676C433EF for ; Sun, 2 Jan 2022 16:11:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B74616B0071; Sun, 2 Jan 2022 11:11:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AFC2F6B0073; Sun, 2 Jan 2022 11:11:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99CD76B0074; Sun, 2 Jan 2022 11:11:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id 86EE46B0071 for ; Sun, 2 Jan 2022 11:11:13 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2C2218249980 for ; Sun, 2 Jan 2022 16:11:13 +0000 (UTC) X-FDA: 78985836426.07.0488523 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id DBECE180007 for ; Sun, 2 Jan 2022 16:11:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2H1LCqOHdwbOruEg3mEr2xyI40SX1AVjLeTz8RJHi7k=; b=rlkr+xeccVk1FJRAZqS5S6Qb6k B3sDhCprjAE1LY/YzCL6pE69UFOIB17uBk8arj7ByJyEjtfkXYrKIv9Lr2oesWVKVZ+PDrR1mRP71 +3EgBUjVnglIFzvp4nu9mY+5IfecCMH8XHFvH4UV7tES+2IZaFiBZobTmoLsX1ctbj+m9aFRTMeax vRX7oppzAkTTmkOcHhyzPqxZRJ+8wYYfed3koBEyRQhyoD3x9WMDjjWRxFc+KODh/niRgaaBk1tI1 Cf1XrtMGLAXm/fZfWs3mDK4oQS33kJH4W6Rt8qguNtdc3ps2nXTUJFAzr11jJZKneLlvI/eo83oYU 9NkgO7+w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n43Rs-00C9GI-4i; Sun, 02 Jan 2022 16:11:08 +0000 Date: Sun, 2 Jan 2022 16:11:08 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 33/48] mm: Add unmap_mapping_folio() Message-ID: References: <20211208042256.1923824-1-willy@infradead.org> <20211208042256.1923824-34-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rlkr+xec; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DBECE180007 X-Stat-Signature: bh53o576oqidm6mfy6o7oni4d5o6btif X-HE-Tag: 1641139871-889980 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 23, 2021 at 08:36:45AM +0100, Christoph Hellwig wrote: > On Wed, Dec 08, 2021 at 04:22:41AM +0000, Matthew Wilcox (Oracle) wrote: > > Convert both callers of unmap_mapping_page() to call unmap_mapping_folio() > > instead. Also move zap_details from linux/mm.h to mm/internal.h > > In fact it could even move to mm/memory.c as no one needs it outside of > that file. __oom_reap_task_mm always passes a NULL zap_details argument > to unmap_page_range. Umm ... no? static inline bool zap_skip_check_mapping(struct zap_details *details, struct page *page) { if (!details || !page) return false; return details->zap_mapping && (details->zap_mapping != page_rmapping(page)); }