From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 317A9C433F5 for ; Mon, 3 Jan 2022 01:44:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B10176B0071; Sun, 2 Jan 2022 20:44:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC0886B0073; Sun, 2 Jan 2022 20:44:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 987526B0074; Sun, 2 Jan 2022 20:44:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id 854616B0071 for ; Sun, 2 Jan 2022 20:44:26 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3F4168F6DC for ; Mon, 3 Jan 2022 01:44:26 +0000 (UTC) X-FDA: 78987280932.28.B546FC7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 43F7B180007 for ; Mon, 3 Jan 2022 01:44:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EretoXD4GqybC5UycdzZfPzyW7EOXt79C0iScoBKGbM=; b=veBBFfcnSTaRWAnthTJ9zQbSc/ cZjpMm09Rc4iPpD1OSom6ht74duGVatK/94dfd3tjzMZ6GbKcqmeBylMGqxljL6i2ezKOSjNb5Ahq HMkAcl95vMZAlrYg1NPNZ4CIa3xqbcf5lqzQMnqjitshUyprjJqMrrm2q92fBs7jPpEF6JgkD3o6B L8GboGbDItNGUehrbEF1HixCm2rJvtu8tgq0kYGfMz3UWZF+FN4jRP8H8cHVNdXgmGO7Ig0/0nNpV ODH4T8h87aAlvowSjQmgDIVWDCXzOQQxA28mFlwrcUhkyKhqW8FoGqg0Gg565W7JlI0v4ZJLvavDt H1u5AZjg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4COe-00CT9Q-Bf; Mon, 03 Jan 2022 01:44:24 +0000 Date: Mon, 3 Jan 2022 01:44:24 +0000 From: Matthew Wilcox To: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 00/48] Folios for 5.17 Message-ID: References: <20211208042256.1923824-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 43F7B180007 X-Stat-Signature: r7ep117aj583k4af3k4g9cgw3hxadojk Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=veBBFfcn; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam11 X-HE-Tag: 1641174264-737045 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 02, 2022 at 04:19:41PM +0000, Matthew Wilcox wrote: > +++ b/include/linux/uio.h > @@ -150,7 +150,7 @@ size_t _copy_from_iter_nocache(void *addr, size_t bytes, struct iov_iter *i); > static inline size_t copy_folio_to_iter(struct folio *folio, size_t offset, > size_t bytes, struct iov_iter *i) > { > - return copy_page_to_iter((struct page *)folio, offset, bytes, i); > + return copy_page_to_iter(&folio->page, offset, bytes, i); > } Mmmpf. I should have tested this more thoroughly. Some files currently include uio.h without including mm_types.h. So this on top fixes the build: +++ b/include/linux/uio.h @@ -7,10 +7,10 @@ #include #include +#include #include struct page; -struct folio; struct pipe_inode_info; struct kvec {