From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53CEBC433FE for ; Mon, 3 Jan 2022 07:53:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0DA26B0072; Mon, 3 Jan 2022 02:53:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B94FD6B0073; Mon, 3 Jan 2022 02:53:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5FD26B0074; Mon, 3 Jan 2022 02:53:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0171.hostedemail.com [216.40.44.171]) by kanga.kvack.org (Postfix) with ESMTP id 97DF96B0072 for ; Mon, 3 Jan 2022 02:53:05 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1A37618162A9B for ; Mon, 3 Jan 2022 07:53:05 +0000 (UTC) X-FDA: 78988209930.10.EC98E38 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf14.hostedemail.com (Postfix) with ESMTP id 002D5100007 for ; Mon, 3 Jan 2022 07:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=azpgps4BioH/lWW2lGgGYjrtEwL1p0tvtjiWboKkgbw=; b=GmvC+KaS6yu0swv3w53v6NX7Hf VIWe9DSwFSOkRgCbq8UNMj1rqmx9aiRPimajP9sW5EfVCGiYa5fkzdRBLThj9Jsyp0xkkt2ztVKpa m/yIxfgjDk7LNHOp6prFVTp/WrqB3jYsx/XUXsN0K4IcHAE2VxuJ86dAjpf3STlWPanaIAEFwMDPm ipIkeufLNkEs5S1tKbiLrvap6PpooMa53skywvJwXoMjU4ukVwtaR4u7sQxekutGEOsWU5A+GiwFE aihH72G8c87SAjNBD21MImuRap/wnDTwXFA6tTbs/JrQSjZRBQCM1elWTFn0xRVW6DvBOtsEVWMrI au/KA4vQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4I9P-008XWx-AJ; Mon, 03 Jan 2022 07:53:03 +0000 Date: Sun, 2 Jan 2022 23:53:03 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 33/48] mm: Add unmap_mapping_folio() Message-ID: References: <20211208042256.1923824-1-willy@infradead.org> <20211208042256.1923824-34-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=GmvC+KaS; dmarc=none; spf=none (imf14.hostedemail.com: domain of BATV+81571d24d82b838d311c+6707+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+81571d24d82b838d311c+6707+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 002D5100007 X-Stat-Signature: odkxp999gqkhiha7o9uzfwb7tg4xoedz X-HE-Tag: 1641196382-884608 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 02, 2022 at 04:11:08PM +0000, Matthew Wilcox wrote: > On Thu, Dec 23, 2021 at 08:36:45AM +0100, Christoph Hellwig wrote: > > On Wed, Dec 08, 2021 at 04:22:41AM +0000, Matthew Wilcox (Oracle) wrote: > > > Convert both callers of unmap_mapping_page() to call unmap_mapping_folio() > > > instead. Also move zap_details from linux/mm.h to mm/internal.h > > > > In fact it could even move to mm/memory.c as no one needs it outside of > > that file. __oom_reap_task_mm always passes a NULL zap_details argument > > to unmap_page_range. > > Umm ... no? > > static inline bool > zap_skip_check_mapping(struct zap_details *details, struct page *page) > { > if (!details || !page) > return false; > > return details->zap_mapping && > (details->zap_mapping != page_rmapping(page)); > } And now check where zap_skip_check_mapping is actually called..