From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2CE0C433EF for ; Tue, 4 Jan 2022 16:10:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0033A6B0071; Tue, 4 Jan 2022 11:10:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF4CD6B0072; Tue, 4 Jan 2022 11:10:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBCA26B0073; Tue, 4 Jan 2022 11:10:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id CB6C46B0071 for ; Tue, 4 Jan 2022 11:10:02 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 82F857F4F5 for ; Tue, 4 Jan 2022 16:10:02 +0000 (UTC) X-FDA: 78993091044.20.1EEDFEC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id B9E4B1A000D for ; Tue, 4 Jan 2022 16:10:01 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AF5966151A; Tue, 4 Jan 2022 16:10:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1017CC36AED; Tue, 4 Jan 2022 16:09:57 +0000 (UTC) Date: Tue, 4 Jan 2022 16:09:54 +0000 From: Catalin Marinas To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , "alex@ghiti.fr" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "will@kernel.org" , "linux-arm-kernel@lists.infradead.org" , Steve Capper Subject: Re: [PATCH v6 03/14] mm: Add len and flags parameters to arch_get_mmap_end() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf19.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B9E4B1A000D X-Stat-Signature: g7k7sc11qinadrnsi8wmp5bqd9c6ng3g X-HE-Tag: 1641312601-107640 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 17, 2021 at 10:27:23AM +0000, Christophe Leroy wrote: > Powerpc needs flags and len to make decision on arch_get_mmap_end(). > > So add them as parameters to arch_get_mmap_end(). > > Signed-off-by: Christophe Leroy > Cc: Steve Capper > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/include/asm/processor.h | 4 ++-- > mm/mmap.c | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h > index 6f41b65f9962..88c696350ace 100644 > --- a/arch/arm64/include/asm/processor.h > +++ b/arch/arm64/include/asm/processor.h > @@ -91,8 +91,8 @@ > #endif /* CONFIG_COMPAT */ > > #ifndef CONFIG_ARM64_FORCE_52BIT > -#define arch_get_mmap_end(addr) ((addr > DEFAULT_MAP_WINDOW) ? TASK_SIZE :\ > - DEFAULT_MAP_WINDOW) > +#define arch_get_mmap_end(addr, len, flags) ((addr > DEFAULT_MAP_WINDOW) ? TASK_SIZE :\ > + DEFAULT_MAP_WINDOW) Nitpick, move the "((addr > ...." on the following line. Either way, Acked-by: Catalin Marinas