From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47FFEC433EF for ; Mon, 10 Jan 2022 08:27:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9F0B6B00A0; Mon, 10 Jan 2022 03:27:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C4F3B6B00A1; Mon, 10 Jan 2022 03:27:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3E376B00A2; Mon, 10 Jan 2022 03:27:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id A6AAE6B00A0 for ; Mon, 10 Jan 2022 03:27:31 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6BF02181F3B5F for ; Mon, 10 Jan 2022 08:27:31 +0000 (UTC) X-FDA: 79013698302.23.19D9581 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id D7CF9A000B for ; Mon, 10 Jan 2022 08:27:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XguF+aztxgNT0rBYdwwwA3zJ1GosA/YJHt/QRh6W5/M=; b=ZapgPiyLDq4beLxPAMi5qVUKa7 QebCkLKr6yt/UI6kjpPGzGqvEYGnvRIE8IvIB8smeIsztWGRegYcKzgtYlQwDELMtFoJdtbgCA0YT aECsOa8wsJQidLGwQz6vwu+cbGD5lQEqAwVsCUAzZWtGyvFWZ9PlCtQKUGigjBCaKTCflZ9WrRMsP 07WdrhqYgSgqukuejuaHsFDa8JRIvnyiuth9VokUArge+GXFjJNpTL22cJ5xHbgWWhLjCRmTw5Rwm fedziu8XdYkGlduH4GU7FYKVwXkjxHb2HNsHD/21qmHtLbVXErbIuIn7EFFcvXCcsP0LSI3CghA21 SMmSOquA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6q1Z-009qfz-Is; Mon, 10 Jan 2022 08:27:29 +0000 Date: Mon, 10 Jan 2022 00:27:29 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, John Hubbard , Christoph Hellwig , William Kucharski , linux-kernel@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH v2 05/28] gup: Change the calling convention for compound_next() Message-ID: References: <20220110042406.499429-1-willy@infradead.org> <20220110042406.499429-6-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220110042406.499429-6-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D7CF9A000B X-Stat-Signature: fwijqrc4ed5cjqb8y81h6q1uiepctgm1 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ZapgPiyL; spf=none (imf25.hostedemail.com: domain of BATV+996bc53df2b455107366+6714+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+996bc53df2b455107366+6714+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-HE-Tag: 1641803250-483162 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 10, 2022 at 04:23:43AM +0000, Matthew Wilcox (Oracle) wrote: > Return the head page instead of storing it to a passed parameter. Looks good, but same comment about maybe passing list and npages first. Reviewed-by: Christoph Hellwig