From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 724D7C433F5 for ; Mon, 10 Jan 2022 08:31:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 101C16B00A0; Mon, 10 Jan 2022 03:31:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B2AB6B00A1; Mon, 10 Jan 2022 03:31:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE39F6B00A2; Mon, 10 Jan 2022 03:31:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0123.hostedemail.com [216.40.44.123]) by kanga.kvack.org (Postfix) with ESMTP id E09E06B00A0 for ; Mon, 10 Jan 2022 03:31:41 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A4BDF8248D52 for ; Mon, 10 Jan 2022 08:31:41 +0000 (UTC) X-FDA: 79013708802.14.F13B217 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP id 3253D40003 for ; Mon, 10 Jan 2022 08:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OfXH7HuA9nnmU4LMS967gWPUmYbFP+jE6Cczd4vRZXQ=; b=A0toOgDZ/7tlodAkcTYqYrCJ+G oMha2mvB9ojaHKjRdf2iBCy+WyO3gEZwyN1G1FhtY2vxukiT9xMP0hatIeLHRRaXsYS8euIKXXZDC Tmph31BEHsULn8/XL27zi4kj7STNC5VjsTi9nI8VQ7y0hisIf2x61aNJAIpWeTKvEGqQEBE3pkdxa KG2Di90YQXGGtEJ0cjmWi6rR/cY2d3FpGWFHWDwyk97tpH0qZCIo1EDtLKULWlXLxA/GRKgbl5fB3 czPvl0talEq6ehY6Sclkfj42gS2QIkX4oSAidyG4IOe7uCOTDq4umD4hh1LTRrqcf54yCSzxaU8+b emUxJvHA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6q5b-009t3P-W8; Mon, 10 Jan 2022 08:31:40 +0000 Date: Mon, 10 Jan 2022 00:31:39 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, John Hubbard , Christoph Hellwig , William Kucharski , linux-kernel@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH v2 09/28] gup: Turn hpage_pincount_add() into page_pincount_add() Message-ID: References: <20220110042406.499429-1-willy@infradead.org> <20220110042406.499429-10-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220110042406.499429-10-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 3253D40003 X-Stat-Signature: eq1ko9waf5gh5bfp1g51dskm9tsd6pk3 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=A0toOgDZ; spf=none (imf11.hostedemail.com: domain of BATV+996bc53df2b455107366+6714+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+996bc53df2b455107366+6714+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam10 X-HE-Tag: 1641803500-977712 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 10, 2022 at 04:23:47AM +0000, Matthew Wilcox (Oracle) wrote: > Simplify try_grab_compound_head() and remove an unnecessary > VM_BUG_ON by handling pages both with and without a pincount field in > page_pincount_add(). Nice: Reviewed-by: Christoph Hellwig