From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4E83C433F5 for ; Mon, 10 Jan 2022 08:32:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6317F6B00A1; Mon, 10 Jan 2022 03:32:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E1B26B00A2; Mon, 10 Jan 2022 03:32:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D0DF6B00A3; Mon, 10 Jan 2022 03:32:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id 3F4796B00A1 for ; Mon, 10 Jan 2022 03:32:07 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0996D181DA0A2 for ; Mon, 10 Jan 2022 08:32:07 +0000 (UTC) X-FDA: 79013709894.20.84313FF Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf26.hostedemail.com (Postfix) with ESMTP id A0E97140013 for ; Mon, 10 Jan 2022 08:32:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yMjG0MO8uve4Q8bknorzIEyXbkOAI9X93aj135DF1W0=; b=lO3XdbhOcfj9hU1fxBfkAzr0Pz Suw2szJm6i+IRLRTJD29IVsf5EyMe0zgKnogUibONVa+vaCmI6y2qaZvlZOaqQACYmik/dL0Y3g1/ XIiy6FRmHfTUc4PwpG2u5h1CMwOIJLL3BeGXnurg4M4zpCwSVOIWhPVCTcn3fb2hSh3UJPt4g6gQi 75KkgZ5+gkhWrYFZ0zGVJMcH8H8QU+JOxn83+w+Wpper3vr5xs02JsIv53uI31BJu4ePG+HFEZ/pv zXM5dsZ0FUyFUbN1wQwXTa5JEOkEVPO1YTdd+gH/WHuOec459CVf/OSrsxQoeklCJl1PUSk6MajKy dQxsbyLQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6q61-009tDJ-Iy; Mon, 10 Jan 2022 08:32:05 +0000 Date: Mon, 10 Jan 2022 00:32:05 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, John Hubbard , Christoph Hellwig , William Kucharski , linux-kernel@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH v2 10/28] gup: Turn hpage_pincount_sub() into page_pincount_sub() Message-ID: References: <20220110042406.499429-1-willy@infradead.org> <20220110042406.499429-11-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220110042406.499429-11-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=lO3XdbhO; dmarc=none; spf=none (imf26.hostedemail.com: domain of BATV+996bc53df2b455107366+6714+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+996bc53df2b455107366+6714+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A0E97140013 X-Stat-Signature: rfr6bu6cobafa5exq7ykd6xr1a8ydogo X-HE-Tag: 1641803526-780340 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 10, 2022 at 04:23:48AM +0000, Matthew Wilcox (Oracle) wrote: > Remove an unnecessary VM_BUG_ON by handling pages both with and without > a pincount field in page_pincount_sub(). Looks good: Reviewed-by: Christoph Hellwig