From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 939FFC433F5 for ; Mon, 10 Jan 2022 08:33:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D4E76B00A1; Mon, 10 Jan 2022 03:33:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 25DC96B00A3; Mon, 10 Jan 2022 03:33:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D8076B00A4; Mon, 10 Jan 2022 03:33:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id F2F176B00A1 for ; Mon, 10 Jan 2022 03:33:21 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id AC9958248D52 for ; Mon, 10 Jan 2022 08:33:21 +0000 (UTC) X-FDA: 79013713002.08.B145768 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP id 66653C000E for ; Mon, 10 Jan 2022 08:33:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=A/43r08mOjVURmRLmz2DPWdTMlAAqU8KbGodPJW3Jjc=; b=42LouDWvMydB5hPBzf+aeK1ucE Qd1QyYTLImOx/kIKmNiVgqLZbL7SfxXgak1WTKmUn73kNUetDuD2FqIWPahrPqnjtI9TQQPI+dt0O ipxaoFnTIt9Uq7PN/OHFMyOJ12gDbclPbvIAAx8JQYA1+KO7d+0LqL1CXHca5nF6b+ncslwpD2rTf sdAH4eKrfpuuPgo5nJMsQqanREka7EGKgV9oDcSR5T7GotnGl/m5AZ7XdQYKOgOFHNObjanwsVtvO 1hxupNWvwazh3kEwniym3O5gVQDvaCftgZUsWAnzKcyg6dw5jKLoYUsnDITA0ksyxhPlIibG1wXZs dWCELxZA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6q7E-009tjr-Ag; Mon, 10 Jan 2022 08:33:20 +0000 Date: Mon, 10 Jan 2022 00:33:20 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, John Hubbard , Christoph Hellwig , William Kucharski , linux-kernel@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH v2 13/28] mm: Add folio_pincount_ptr() Message-ID: References: <20220110042406.499429-1-willy@infradead.org> <20220110042406.499429-14-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220110042406.499429-14-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 66653C000E X-Stat-Signature: h81djr1f4ccwjdci8c1awe1qg85u4hw1 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=42LouDWv; dmarc=none; spf=none (imf10.hostedemail.com: domain of BATV+996bc53df2b455107366+6714+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+996bc53df2b455107366+6714+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam02 X-HE-Tag: 1641803601-943130 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 10, 2022 at 04:23:51AM +0000, Matthew Wilcox (Oracle) wrote: > +static inline atomic_t *folio_pincount_ptr(struct folio *folio) > +{ > + struct page *tail = &folio->page + 1; > + return &tail->compound_pincount; > +} And empty line after the declaration would be nice here. Otherwise looks good: Reviewed-by: Christoph Hellwig