From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4831FC433F5 for ; Mon, 10 Jan 2022 08:37:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D30F36B00A2; Mon, 10 Jan 2022 03:37:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE10D6B00A3; Mon, 10 Jan 2022 03:37:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD0C36B00A4; Mon, 10 Jan 2022 03:37:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id B03A66B00A2 for ; Mon, 10 Jan 2022 03:37:20 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 719E9182057E9 for ; Mon, 10 Jan 2022 08:37:20 +0000 (UTC) X-FDA: 79013723040.18.E4633C5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id 29DF1A0006 for ; Mon, 10 Jan 2022 08:37:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DpKvSwxbbfQbLZApW/SnZkrEtdEJ/1VZArTMlGDXrSM=; b=Y7BsiipGKK2DffmCmd+iLr0YAk V6JtBSMvnBLFpbxfWYrUkKYID7QJs3IFPJks+isIeD8pDYZx0VHkqLLKE4nhn5sjXCADItWkKgquQ 2shiUoZFHPNvciDHeWQaOK3tc4Oc/Iv5RuzmxuK42ea5NgCs7CJw9tnKZ81i5ofmWG5ZR4Oc/OUai 4SmqWj9ldQ4UiTsh+0B96aWwz2UgLYsXaVVJ/Y/SPdbRdDbdJS/8PSVzYuIMcRfh+w8FLqpwQplca 4NWpcN1RVFrvkMZFOEYnrWnfDOk5MIZX8ZDQZ5rgH6wlmSBJg2N4HwD/rTQ/w/vvW1bGSIQjubkX+ Su0VXJjQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6qB5-009vpK-1N; Mon, 10 Jan 2022 08:37:19 +0000 Date: Mon, 10 Jan 2022 00:37:19 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, John Hubbard , Christoph Hellwig , William Kucharski , linux-kernel@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH v2 20/28] gup: Convert gup_pte_range() to use a folio Message-ID: References: <20220110042406.499429-1-willy@infradead.org> <20220110042406.499429-21-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220110042406.499429-21-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Y7BsiipG; spf=none (imf25.hostedemail.com: domain of BATV+996bc53df2b455107366+6714+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+996bc53df2b455107366+6714+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Queue-Id: 29DF1A0006 X-Stat-Signature: eaoa7a48s7h7abniz7tbkg6u1xr17jfn X-Rspamd-Server: rspam04 X-HE-Tag: 1641803839-450787 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 10, 2022 at 04:23:58AM +0000, Matthew Wilcox (Oracle) wrote: > We still call try_grab_folio() once per PTE; a future patch could > optimise to just adjust the reference count for each page within > the folio. Looks good, Reviewed-by: Christoph Hellwig