From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 965A5C433EF for ; Mon, 10 Jan 2022 13:41:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DAE76B0075; Mon, 10 Jan 2022 08:41:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 08A206B0078; Mon, 10 Jan 2022 08:41:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E94326B007B; Mon, 10 Jan 2022 08:41:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id D66906B0075 for ; Mon, 10 Jan 2022 08:41:42 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9D7CC944CA for ; Mon, 10 Jan 2022 13:41:42 +0000 (UTC) X-FDA: 79014490044.13.31FDD88 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 3ECC6140011 for ; Mon, 10 Jan 2022 13:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jEw1SOvY92ZLm66igAJigZ2cImKkRwTS7WJcjKMowwI=; b=ZYsbOjm6qM/0j4QWWVpw2el5vC UmUG9ZBMHdMeff+4RtSTOGJMxt7HtXSXEeQsVgTBB0eFEa1RYJMpOZktVVyqJj8A62+kCsU+iuAPb Z2iqpUrDfIY9nLTnCTfd5byDb17FT7klWexH6e6e76q/r2xNcZU3fM78JCQL5xRmlw87LVlzUH5J6 6IpoeWPYqq6xaUpqvIf4gyCuZCJRfQ2WQO/Vyo09Vhq5K8wGD4DhgaChoHAEJzGI1gVH4pMvQ+EyZ tmiF0LJoPZgETqAY7ayID1H13spCAZS17GnQt2sM7xF7HcTbGE1/TU9vyjsDN0qXN38qO/6Is4TmK 8/osPAOA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6uvb-002SjP-Jl; Mon, 10 Jan 2022 13:41:39 +0000 Date: Mon, 10 Jan 2022 13:41:39 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-mm@kvack.org, John Hubbard , William Kucharski , linux-kernel@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH v2 26/28] gup: Convert compound_range_next() to gup_folio_range_next() Message-ID: References: <20220110042406.499429-1-willy@infradead.org> <20220110042406.499429-27-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 3ECC6140011 X-Stat-Signature: 8i1dw51zgcgxiseibjoqgrk4wht8xxry Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZYsbOjm6; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam02 X-HE-Tag: 1641822102-532622 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 10, 2022 at 12:41:22AM -0800, Christoph Hellwig wrote: > On Mon, Jan 10, 2022 at 04:24:04AM +0000, Matthew Wilcox (Oracle) wrote: > > +static inline struct folio *gup_folio_range_next(unsigned long i, > > unsigned long npages, struct page *start, unsigned int *ntails) > > { > > - struct page *next, *page; > > + struct page *next; > > + struct folio *folio; > > unsigned int nr = 1; > > > > next = nth_page(start, i); > > + folio = page_folio(next); > > Superficial nit: initialization next and folio at declaration time > would reada little better. Done. Also the previous patch: -static inline struct page *compound_next(struct page **list, +static inline struct folio *gup_folio_next(struct page **list, unsigned long npages, unsigned long i, unsigned int *ntails) { - struct page *page; + struct folio *folio = page_folio(list[i]); unsigned int nr; - page = compound_head(list[i]); for (nr = i + 1; nr < npages; nr++) {