From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25367C433EF for ; Mon, 24 Jan 2022 08:50:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6F086B0081; Mon, 24 Jan 2022 03:50:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A1D866B0083; Mon, 24 Jan 2022 03:50:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90CF36B0085; Mon, 24 Jan 2022 03:50:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id 852CE6B0081 for ; Mon, 24 Jan 2022 03:50:00 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4534A1815B7CA for ; Mon, 24 Jan 2022 08:50:00 +0000 (UTC) X-FDA: 79064558160.18.CDAAE7E Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id E11E240011 for ; Mon, 24 Jan 2022 08:49:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xyivSDGY+EBgTLLx3+YqxywRSiggQuJ6OFlbqF42w1Q=; b=Rvmtrcn8y47mAEE6mhP78/5kNr 04j7U3Kh22adgIT/viRnnfGhDY2mnAFpnAW7ejqelo2CmkaCI1UmZQXXW3Hn7DIdF0A9G5IdpixDZ MAoeYw2XNMJ37bzfy9IgqdZv7Ax8gPLiCrSjhtU79CSTWHS6od+cJvOwkd575tRpj7hxMUZTgKojZ Wa+1x7vGHDW1c+5zlea6lyH3PR30gj1GFw4sjgnw9KplAiVOLWTmOZY8pX6qa9qUDKhLLIn8T8a83 M/8xbQx67hvwdVLCbyOvpMmZ2bg5b/lchaehixXjpgvD0zVidvyss33wXGS+Fx9HNPVn/+JQYhsvv kGxsh9KA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBv2w-002eBq-Km; Mon, 24 Jan 2022 08:49:54 +0000 Date: Mon, 24 Jan 2022 00:49:54 -0800 From: Christoph Hellwig To: NeilBrown Cc: Trond Myklebust , Anna Schumaker , Chuck Lever , Andrew Morton , Mel Gorman , Christoph Hellwig , David Howells , linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/23] MM: perform async writes to SWP_FS_OPS swap-space using ->swap_rw Message-ID: References: <164299573337.26253.7538614611220034049.stgit@noble.brown> <164299611277.26253.18349860115008677213.stgit@noble.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164299611277.26253.18349860115008677213.stgit@noble.brown> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Rvmtrcn8; dmarc=none; spf=none (imf27.hostedemail.com: domain of BATV+b18af077b488c69bdec9+6728+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b18af077b488c69bdec9+6728+infradead.org+hch@bombadil.srs.infradead.org X-Stat-Signature: nk9qsmez5z7w51bgtdr6emkfxpi5fqcz X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E11E240011 X-HE-Tag: 1643014199-709971 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 24, 2022 at 02:48:32PM +1100, NeilBrown wrote: > > +static void sio_write_complete(struct kiocb *iocb, long ret) > +{ > + struct swap_iocb *sio = container_of(iocb, struct swap_iocb, iocb); > + struct page *page = sio->bvec.bv_page; > + > + if (ret != 0 && ret != PAGE_SIZE) { ret == 0 isn't really a success case for ki_complete, it is something that should never happen at all. Otherwise looks good: Reviewed-by: Christoph Hellwig