From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 307E9C433F5 for ; Mon, 24 Jan 2022 08:57:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C60CC6B0081; Mon, 24 Jan 2022 03:57:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C10DC6B0085; Mon, 24 Jan 2022 03:57:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B27A36B0087; Mon, 24 Jan 2022 03:57:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A66BE6B0081 for ; Mon, 24 Jan 2022 03:57:40 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 61661181C49C8 for ; Mon, 24 Jan 2022 08:57:40 +0000 (UTC) X-FDA: 79064577480.28.EA4716B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP id 2142040038 for ; Mon, 24 Jan 2022 08:57:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=asCzRIoppSmO4QZ+TuOt/SZMZHwp70x1LmUoq7XNu7Q=; b=wkisxQoTZF4xxUhI4XNl0vmyAb NaQNpYi3/atnNwVIRwialv+9VcPJBMjLRySEa8ydT6FiRSbl3p+KlrMFOb8aEszRtMn3Njn84hhTb MWmCM0HL65mpZm9l8tb+eLPX/hfVz50HuZg3Fvchqe7NxMVrELHqms3SDzFEKhVqrkewzcmlcKI5f jJuRh2H3JzAT7C3+N1jwFYKo3Ue93W1sUv1zjcmfb7VQOi3Vtl1pEiUrVs0S878556JItPFPjaQXm 4l0u5c/SWH9uOUFgZAz48eeh+MpxA+ZQBgTF1GErn6OCo393nweUWLLiHH7rZfe1k2W7itdFBHo96 XeVt/e9w==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBvAM-002hYe-PY; Mon, 24 Jan 2022 08:57:34 +0000 Date: Mon, 24 Jan 2022 00:57:34 -0800 From: Christoph Hellwig To: NeilBrown Cc: Trond Myklebust , Anna Schumaker , Chuck Lever , Andrew Morton , Mel Gorman , Christoph Hellwig , David Howells , linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/23] NFS: rename nfs_direct_IO and use as ->swap_rw Message-ID: References: <164299573337.26253.7538614611220034049.stgit@noble.brown> <164299611281.26253.6497855219394305186.stgit@noble.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164299611281.26253.6497855219394305186.stgit@noble.brown> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=wkisxQoT; dmarc=none; spf=none (imf12.hostedemail.com: domain of BATV+b18af077b488c69bdec9+6728+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b18af077b488c69bdec9+6728+infradead.org+hch@bombadil.srs.infradead.org X-Stat-Signature: soqsj9uo9sumo6knz1mnh7xuygh9dufh X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2142040038 X-HE-Tag: 1643014659-730334 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +extern int nfs_swap_rw(struct kiocb *, struct iov_iter *); Might be worth to drop the pointless extern while you're at it. Otherwise looks good: Reviewed-by: Christoph Hellwig