From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9C41C433F5 for ; Mon, 24 Jan 2022 12:32:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EFBD6B0081; Mon, 24 Jan 2022 07:32:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 59F0F6B0083; Mon, 24 Jan 2022 07:32:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48D916B0085; Mon, 24 Jan 2022 07:32:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by kanga.kvack.org (Postfix) with ESMTP id 397E26B0081 for ; Mon, 24 Jan 2022 07:32:28 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id ED08D181C967B for ; Mon, 24 Jan 2022 12:32:27 +0000 (UTC) X-FDA: 79065118734.15.9262CA8 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id AB32CC0021 for ; Mon, 24 Jan 2022 12:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Z2gGoEVk8Y/k11EEWsaZZW9coZbG9Md8ydPQy8yxQzo=; b=Vq9EghPrqQ1SCPzCGV/Usy8QQ1 irUoY6542/6bq7exJ7BO0wU4Je9ALTjesoyZ27H8Y2HNLj0v3eJCXQDKavRRAGAT2qhyG1ESM3X31 VAvbvol1wOkEx8sXL6kWjL7aKoUXgofoiexsWaCTGNbYy7Eusseno0T7nUAJi0ef98UO8jXVid3DV EhuAg0lTdEgmhTpWnZyey3sZehcKL4b/CxiHim1lq0ThJvVzh8z6mlSJArmJZfC41SKgeeM3z6vI3 dR3dLQ6be5L6Ypu1BAe1oLeC/yHUXJ4J173D29hFAIoyL8y72O2zHLyihqkMBlqAQjiL3CAI4V+2T R7EVJJ4A==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nByW4-003Hmi-5y; Mon, 24 Jan 2022 12:32:12 +0000 Date: Mon, 24 Jan 2022 04:32:12 -0800 From: Christoph Hellwig To: Christophe Leroy Cc: Luis Chamberlain , Jessica Yu , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "kgdb-bugreport@lists.sourceforge.net" , "linux-mm@kvack.org" , "linux-arch@vger.kernel.org" Subject: Re: [PATCH 1/7] modules: Refactor within_module_core() and within_module_init() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AB32CC0021 X-Stat-Signature: e3ybtgfp47sb8hw7biu1je599wzatdqp Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Vq9EghPr; dmarc=none; spf=none (imf28.hostedemail.com: domain of BATV+b18af077b488c69bdec9+6728+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b18af077b488c69bdec9+6728+infradead.org+hch@bombadil.srs.infradead.org X-HE-Tag: 1643027546-665786 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 24, 2022 at 09:22:15AM +0000, Christophe Leroy wrote: > +static inline bool within_range(unsigned long addr, void *base, unsigned int size) Please avoid the overly long line. .. But given that this function only has a single caller I see no point in factoring it out anyway.