From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 576A1C433F5 for ; Fri, 14 Jan 2022 11:07:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 952036B0072; Fri, 14 Jan 2022 06:07:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 928896B0073; Fri, 14 Jan 2022 06:07:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 817586B0074; Fri, 14 Jan 2022 06:07:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id 70F936B0072 for ; Fri, 14 Jan 2022 06:07:16 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 35319182331B2 for ; Fri, 14 Jan 2022 11:07:16 +0000 (UTC) X-FDA: 79028616072.03.54449BF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id D23E11C0015 for ; Fri, 14 Jan 2022 11:07:15 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CE41561EE9; Fri, 14 Jan 2022 11:07:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26181C36AE5; Fri, 14 Jan 2022 11:07:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642158434; bh=rg04tT8R1FkbVTYI0SCSCtVRaw71c3Km2IEW1JE51T4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QmK6P2ERTNTveN2AIVdc6Lnz3VzhcoPkYWRz3fR9Y0QTcs/iKutdB1GOzjm5pX3CO 7edBo8SNpYe4DWdGV73ntqSi+gUcrRdeUS5ahZ/R5+z5R2GKqgDimdxk2/vXM0XxKZ hDdW+Iiq8p8Jjd8OuWUonO7ylUrE2cl9VXuKNk5GhadV2F7gwcrmUk/CZhBXSWb0+8 W4j0mKwZHQOLAM3MZGm0BgctEep/5hg1fsr9vPGpVEb3me3N6+e0RAYOpjppChkMM1 KLjsilIw3SY9lAipeHc/tICBEHJBwvl1pGkKlTefDkI5s7pagKZnsZVNWMPG4Xv73F T1UCuSqIlcBRg== Date: Fri, 14 Jan 2022 13:07:05 +0200 From: Mike Rapoport To: Wei Yang Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, shakeelb@google.com, guro@fb.com, vbabka@suse.cz, willy@infradead.org, songmuchun@bytedance.com, shy828301@gmail.com, surenb@google.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/4] mm/memcg: use NUMA_NO_NODE to indicate allocation from unspecified node Message-ID: References: <20220111010302.8864-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220111010302.8864-1-richard.weiyang@gmail.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: D23E11C0015 X-Stat-Signature: rk5h11yine7d9xj9ywkm5j8wcoqtpeiw Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QmK6P2ER; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org X-HE-Tag: 1642158435-136713 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 11, 2022 at 01:02:59AM +0000, Wei Yang wrote: > Instead of use "-1", let's use NUMA_NO_NODE for consistency. > > Signed-off-by: Wei Yang Reviewed-by: Mike Rapoport > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 2ed5f2a0879d..11715f7323c0 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5054,7 +5054,7 @@ static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) > * function. > */ > if (!node_state(node, N_NORMAL_MEMORY)) > - tmp = -1; > + tmp = NUMA_NO_NODE; > pn = kzalloc_node(sizeof(*pn), GFP_KERNEL, tmp); > if (!pn) > return 1; > -- > 2.33.1 > > -- Sincerely yours, Mike.