From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34396C433F5 for ; Tue, 18 Jan 2022 09:21:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 820156B0072; Tue, 18 Jan 2022 04:21:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CED76B0073; Tue, 18 Jan 2022 04:21:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 697336B0074; Tue, 18 Jan 2022 04:21:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0065.hostedemail.com [216.40.44.65]) by kanga.kvack.org (Postfix) with ESMTP id 5A4F26B0072 for ; Tue, 18 Jan 2022 04:21:27 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1691C181CC1D9 for ; Tue, 18 Jan 2022 09:21:27 +0000 (UTC) X-FDA: 79042864614.11.09B57EE Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) by imf06.hostedemail.com (Postfix) with ESMTP id B48D5180004 for ; Tue, 18 Jan 2022 09:21:26 +0000 (UTC) Received: by mail-il1-f171.google.com with SMTP id d3so16979463ilr.10 for ; Tue, 18 Jan 2022 01:21:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5Zvs9+UMuisbE1S/G8Xv89qZmGNrRAyujh7XOE4Gpac=; b=WNs7c1MTDzC9jGA7BOWDtnQYV9lhuodolnBJBBDhbPGOnvPzIRjK3ikEJe7FpeZWF7 khHNeCGff946aku7HKG4YWIraUbOgbcrban0UwppU+ZvLt5FwAd90Z6C41CEY9fpyNod 4Xx8cWlhS025exLxB0ao3sOAsRH921YrlE6z/uUtrHvv9SJWc7VY4EtPUyfSiDaKKqDr hdRPjoope/KEeIneL+fkDjaHzun/u6EFFCHd0Gd10PGXeSknHaoyHcUEGJ8+UtjhrZwc 4q2WEwVmfoZON9nDK44fxgg7jqC5p7GuiDxZalbaTsqTm1pcX8RGq7sGmeYCmQLq9QSa nv2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5Zvs9+UMuisbE1S/G8Xv89qZmGNrRAyujh7XOE4Gpac=; b=qD6cif1s0t89ym9Brl4c87nT4/zkAkjnw/MtMfVsOS9GtO9Ar17xvE+RgPNqsudtvV 7+GrXpfvdp2wrl02H1m5ZNG8SBRX2xfbuFQugusPbgLKGLBLhQdDQkasQRbERjV8UWoD TIQ5KCC6mfVS1yEbU+xloissXsLxiKrg1aAeCd5Nh55veWBCHdkuMLORssdDUPp2LpOf f0o5ar3dESN7UIrOGLZt6uybOVHGshrH2pZB7Iisgm95KosvuGaNcPRdj48j7cbBZ4eA iTXAod7he2u3Io4qnpAzYcLvw9khUYOx53ghBMnJfsw8LhULDLiPkY4IzA4PBfovf7UA o3XQ== X-Gm-Message-State: AOAM532G2uHiWAzTBOlZ9jquC2OQ9yZmDLHmAUGSA2To+5BuPXe2dDek N8aUnyvgg8hfXOzbE1BfA8MEBg== X-Google-Smtp-Source: ABdhPJzuNClvh26yBkKaIbqUIdOMn/cTG48kphsbceegwXKy1WFnvwj3FQC5I7nUchi8DS+vx4TyJA== X-Received: by 2002:a92:cd4b:: with SMTP id v11mr7081222ilq.3.1642497685350; Tue, 18 Jan 2022 01:21:25 -0800 (PST) Received: from google.com ([2620:15c:183:200:40dc:e0ca:c949:a83b]) by smtp.gmail.com with ESMTPSA id o10sm2389761iow.0.2022.01.18.01.21.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jan 2022 01:21:24 -0800 (PST) Date: Tue, 18 Jan 2022 02:21:21 -0700 From: Yu Zhao To: Donald Carr Cc: Andi Kleen , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, page-reclaim@google.com, x86@kernel.org, Andrew Morton , Linus Torvalds Subject: Re: [PATCH v6 0/9] Multigenerational LRU Framework Message-ID: References: <20220104202227.2903605-1-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B48D5180004 X-Stat-Signature: zob9o9b8eq8wxbn5dykdyi7emj11j4g8 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=WNs7c1MT; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.171 as permitted sender) smtp.mailfrom=yuzhao@google.com X-HE-Tag: 1642497686-387966 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 11, 2022 at 01:41:22AM -0700, Yu Zhao wrote: > On Tue, Jan 04, 2022 at 01:30:00PM -0700, Yu Zhao wrote: > > On Tue, Jan 04, 2022 at 01:22:19PM -0700, Yu Zhao wrote: > > > TLDR > > > ==== > > > The current page reclaim is too expensive in terms of CPU usage and it > > > often makes poor choices about what to evict. This patchset offers an > > > alternative solution that is performant, versatile and > > > straightforward. > > > > > > > > > Summery > > > ======= > > > The facts are: > > > 1. The independent lab results and the real-world applications > > > indicate substantial improvements; there are no known regressions. > > > 2. Thrashing prevention, working set estimation and proactive reclaim > > > work out of the box; there are no equivalent solutions. > > > 3. There is a lot of new code; nobody has demonstrated smaller changes > > > with similar effects. > > > > > > Our options, accordingly, are: > > > 1. Given the amount of evidence, the reported improvements will likely > > > materialize for a wide range of workloads. > > > 2. Gauging the interest from the past discussions [14][15][16], the > > > new features will likely be put to use for both personal computers > > > and data centers. > > > 3. Based on Google's track record, the new code will likely be well > > > maintained in the long term. It'd be more difficult if not > > > impossible to achieve similar effects on top of the existing > > > design. > > > > Hi Andrew, Linus, > > > > Can you please take a look at this patchset and let me know if it's > > 5.17 material? > > > > My goal is to get it merged asap so that users can reap the benefits > > and I can push the sequels. Please examine the data provided -- I > > think the unprecedented coverage and the magnitude of the improvements > > warrant a green light. My gratitude to Donald who has been helping test MGLRU since v2: Donald Carr (d@chaos-reins.com) Founder of Chaos Reins (http://chaos-reins.com), an SF based consultancy company specializing in designing/creating embedded Linux appliances. Can you please provide your Tested-by tags? This will ensure the credit for your contributions. Thanks!