From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A54A3C433F5 for ; Thu, 20 Jan 2022 08:47:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E2856B00AD; Thu, 20 Jan 2022 03:47:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 192946B00AE; Thu, 20 Jan 2022 03:47:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0817B6B00B0; Thu, 20 Jan 2022 03:47:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0124.hostedemail.com [216.40.44.124]) by kanga.kvack.org (Postfix) with ESMTP id ECA476B00AD for ; Thu, 20 Jan 2022 03:47:36 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9DCA1951B1 for ; Thu, 20 Jan 2022 08:47:36 +0000 (UTC) X-FDA: 79050036912.23.9ADB0D7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf07.hostedemail.com (Postfix) with ESMTP id 148D440003 for ; Thu, 20 Jan 2022 08:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fNusMrWQ+iaAxCx5W24yZJ93BWZfAuFDm6S8/KGzbK0=; b=D39kfHS+T/0kWsqL02joFtiv09 ubeTypbD4543NiZpFkfezmtBZWQPlrZpYwm/nLxZD9YK8pWH41dX2UJdscRc7NmMJvro+lxKIaBId K7jnSerZ73JAr+mJgGNAbVwjVHOW9sFo2xVDGlluJ5YFRPbCzMgZWrwNKA1PwHpa3SU0W6DbeyEZM 8Jhb0XYD0mJ+HB19llClYpTW+tEqw/tkvKNOsFZfQsn8N3aCVrg/s/BVVvN1k/LtRGQa2vqe92Uv8 WYO1RKbzkm+czYu/+x0/YVypor1v53PG6zh7AENpjveWc5STtRuijyEz/bq9rbZuNmyIZsgE89SL4 P4DvTPTw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAT6S-009tud-Lg; Thu, 20 Jan 2022 08:47:32 +0000 Date: Thu, 20 Jan 2022 00:47:32 -0800 From: Christoph Hellwig To: Shiyang Ruan Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org, jane.chu@oracle.com Subject: Re: [PATCH v9 07/10] mm: move pgoff_address() to vma_pgoff_address() Message-ID: References: <20211226143439.3985960-1-ruansy.fnst@fujitsu.com> <20211226143439.3985960-8-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211226143439.3985960-8-ruansy.fnst@fujitsu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 148D440003 X-Stat-Signature: th1kmk65hw55i3m1cu7ihz9knrb48kgj Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=D39kfHS+; spf=none (imf07.hostedemail.com: domain of BATV+0328028a7a74e2859a11+6724+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0328028a7a74e2859a11+6724+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-HE-Tag: 1642668455-292298 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 26, 2021 at 10:34:36PM +0800, Shiyang Ruan wrote: > Since it is not a DAX-specific function, move it into mm and rename it > to be a generic helper. > > Signed-off-by: Shiyang Ruan Looks good, Reviewed-by: Christoph Hellwig