From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A650C433F5 for ; Thu, 20 Jan 2022 08:59:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A36266B00A8; Thu, 20 Jan 2022 03:59:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E6F86B00AA; Thu, 20 Jan 2022 03:59:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FC3A6B00B2; Thu, 20 Jan 2022 03:59:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id 80C6F6B00A8 for ; Thu, 20 Jan 2022 03:59:16 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3FF4695CA7 for ; Thu, 20 Jan 2022 08:59:16 +0000 (UTC) X-FDA: 79050066312.11.3C9F217 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP id F1B9A1C000C for ; Thu, 20 Jan 2022 08:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=x4NWNJFPfdMZ6dsxs51T9yAg2PQobfgRFikQN4MZqzY=; b=FHhtYapIjaAV9Yu0e8p4as5cUI aLvqiavV/GyFE1ELMqo1eVzTacOs46MHeUg4nb2Mm9oQQ1E4itDmuqNTNgeB78SqXGjFRpiByAjEg oxiZOaaVVcXizkwYRFTDzlEFqekvTPbIYz9CYKGt9mC3gqNzcTdWk7GzZjkg48Ej9jmzFJADmE+d0 k8AkTCFAvI6yiIeDiOqW5Iw5P5mOJK99ga86NjtQWHg2h7ZX9hKoL0jKWewNBECzWIrz60+X698sa Ey+kFJZygvziErE+CbCiPZS7GtDtUc86AopRC0sIsNWyjm3lvCHOBbUyD606ZJ46pd/Rtp0Qta0Fw fAfkSUYQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nATHk-009z93-IJ; Thu, 20 Jan 2022 08:59:12 +0000 Date: Thu, 20 Jan 2022 00:59:12 -0800 From: Christoph Hellwig To: Shiyang Ruan Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org, jane.chu@oracle.com Subject: Re: [PATCH v9 10/10] fsdax: set a CoW flag when associate reflink mappings Message-ID: References: <20211226143439.3985960-1-ruansy.fnst@fujitsu.com> <20211226143439.3985960-11-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211226143439.3985960-11-ruansy.fnst@fujitsu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: F1B9A1C000C X-Stat-Signature: wax573f59fsnabomixpdyb7prfih4w56 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=FHhtYapI; dmarc=none; spf=none (imf18.hostedemail.com: domain of BATV+0328028a7a74e2859a11+6724+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0328028a7a74e2859a11+6724+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam03 X-HE-Tag: 1642669155-191793 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 26, 2021 at 10:34:39PM +0800, Shiyang Ruan wrote: > +#define FS_DAX_MAPPING_COW 1UL > + > +#define MAPPING_SET_COW(m) (m = (struct address_space *)FS_DAX_MAPPING_COW) > +#define MAPPING_TEST_COW(m) (((unsigned long)m & FS_DAX_MAPPING_COW) == \ > + FS_DAX_MAPPING_COW) These really should be inline functions and probably use lower case names. But different question, how does this not conflict with: #define PAGE_MAPPING_ANON 0x1 in page-flags.h? Either way I think this flag should move to page-flags.h and be integrated with the PAGE_MAPPING_FLAGS infrastucture.