From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Maor Gottlieb <maorg@nvidia.com>,
torvalds@linux-foundation.org, tglx@linutronix.de, hch@lst.de,
linux-mm@kvack.org
Subject: Re: [PATCH] tools/testing/scatterlist: Add missing defines
Date: Wed, 26 Jan 2022 08:16:31 +0100 [thread overview]
Message-ID: <YfD1T9pwqMVB8ISq@linutronix.de> (raw)
In-Reply-To: <20220125184413.885fbbdf5609d88544e72dd2@linux-foundation.org>
On 2022-01-25 18:44:13 [-0800], Andrew Morton wrote:
> On Tue, 18 Jan 2022 10:21:05 +0200 Maor Gottlieb <maorg@nvidia.com> wrote:
>
> > The cited commits replaced preemptible with pagefault_disabled and
> > flush_kernel_dcache_page with flush_dcache_page respectively, hence
> > need to update the corresponding defines in the test.
>
> What are the effects of this change? Does it fix compilation
> issues? Runtime issues? If so, what are those issues?
There is this runtime test
tools/testing/scatterlist/main.c
and without the changes to
tools/testing/scatterlist/linux/mm.h
it simply does not compile. Since it is userland, the kernel details
like preemptible() or pagefault_disabled() don't matter much, it has
just to compile and run.
Sebastian
prev parent reply other threads:[~2022-01-26 7:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 8:21 [PATCH] tools/testing/scatterlist: Add missing defines Maor Gottlieb
2022-01-18 14:40 ` Sebastian Andrzej Siewior
2022-01-26 2:44 ` Andrew Morton
2022-01-26 7:16 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfD1T9pwqMVB8ISq@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=linux-mm@kvack.org \
--cc=maorg@nvidia.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).