From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B42DEC2BA4C for ; Wed, 26 Jan 2022 07:16:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FE3F6B0075; Wed, 26 Jan 2022 02:16:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1886C6B0078; Wed, 26 Jan 2022 02:16:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 028926B007B; Wed, 26 Jan 2022 02:16:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id E812B6B0075 for ; Wed, 26 Jan 2022 02:16:35 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A0DA91849A3AB for ; Wed, 26 Jan 2022 07:16:35 +0000 (UTC) X-FDA: 79071580350.14.18E2B09 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf03.hostedemail.com (Postfix) with ESMTP id E540720006 for ; Wed, 26 Jan 2022 07:16:34 +0000 (UTC) Date: Wed, 26 Jan 2022 08:16:31 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1643181392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FgkC9xSJ8xElHu7p5Tc6Y98mLL93jG/5FEHoT9aAErQ=; b=uBJcpCdyIoh+AXbsBqq/rKSfo+hoylFxDSgv5pQ91W6uT2wKRA/LraGAUKMiIc6Fad666J hwQCGhMXIjOmb+tTXBnXwrQR5Mv/p1YJYEgGO2R7bYQlcLiPe6O3zsdlD/qHuyVnwDxVoa azKq+ayu+lECtUUP4z3x13/YT55xNniCklWTfsjo9KPAbUkvRpIoF+DV62J5IT9PywZZrM mib3N4+CQJY95AJavk2kbjrwBlmQOqtHXtARABEJaaSm/Vxs5UTn2I12lbSdlTVnuNZJQg O2M46K9YQEhchV66Psoz+kFutclPEqFE6OFcPmn6GQCRjO2HqL02XM62b0X/VQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1643181392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FgkC9xSJ8xElHu7p5Tc6Y98mLL93jG/5FEHoT9aAErQ=; b=eBWQYOyviVMy5JEnAnv/IMAFCknHXDQSzygHWzeSIgnRPO6Ia9/30fKHB2A0atWKWy4Vcf gncPH+NRXt0/OMDg== From: Sebastian Andrzej Siewior To: Andrew Morton Cc: Maor Gottlieb , torvalds@linux-foundation.org, tglx@linutronix.de, hch@lst.de, linux-mm@kvack.org Subject: Re: [PATCH] tools/testing/scatterlist: Add missing defines Message-ID: References: <20220118082105.1737320-1-maorg@nvidia.com> <20220125184413.885fbbdf5609d88544e72dd2@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220125184413.885fbbdf5609d88544e72dd2@linux-foundation.org> X-Stat-Signature: u8jjwk58eyu6x483ar789o4wpz37j3aj X-Rspam-User: nil Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=uBJcpCdy; dkim=pass header.d=linutronix.de header.s=2020e header.b=eBWQYOyv; spf=pass (imf03.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E540720006 X-HE-Tag: 1643181394-966740 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022-01-25 18:44:13 [-0800], Andrew Morton wrote: > On Tue, 18 Jan 2022 10:21:05 +0200 Maor Gottlieb wrote: > > > The cited commits replaced preemptible with pagefault_disabled and > > flush_kernel_dcache_page with flush_dcache_page respectively, hence > > need to update the corresponding defines in the test. > > What are the effects of this change? Does it fix compilation > issues? Runtime issues? If so, what are those issues? There is this runtime test tools/testing/scatterlist/main.c and without the changes to tools/testing/scatterlist/linux/mm.h it simply does not compile. Since it is userland, the kernel details like preemptible() or pagefault_disabled() don't matter much, it has just to compile and run. Sebastian