From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F700C2BA4C for ; Wed, 26 Jan 2022 07:16:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EE7C6B0078; Wed, 26 Jan 2022 02:16:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 978BC6B007B; Wed, 26 Jan 2022 02:16:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F0D06B007D; Wed, 26 Jan 2022 02:16:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id 6FB7D6B0078 for ; Wed, 26 Jan 2022 02:16:42 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 301898E56A for ; Wed, 26 Jan 2022 07:16:42 +0000 (UTC) X-FDA: 79071580644.10.EA38CBA Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP id BBD8480004 for ; Wed, 26 Jan 2022 07:16:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1YiAgXr+T+5PoTxk9FObhMmaDmPyu89BDQODNplz5ss=; b=tR1PVeVh0kUvMiGgRtLM2fOQ8K a2KuIVjewWnSb8v44m2iDOO4jcZ36NweKW2xo/+IVLcoIhsnwEcwtI2eswSVYIGlV9JzePM5fNiQb u2ZuFweoqGoljY/MUDiHc7UNTX+VHt+SB2j5U/ZMAd0UK8BYLe9g5l5t1c5Md24DEB//oX0QKnHwH +fQcsHq4euN5yXeFa7mHf4DEDk7k4mkQqhyEWaOXf53iKvwYp7He+KSNG+vUBAyRpQekvDhORzD90 ADb0uW8dydlFFMuwv4GhnU+CjKnprYYDHiFuNEhfsDZNN2MvSVYLn/0Nm2L2m+Hn4IeOcuUDoaWnu 0Oim0frQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCcXo-00ASlK-KM; Wed, 26 Jan 2022 07:16:40 +0000 Date: Tue, 25 Jan 2022 23:16:40 -0800 From: Christoph Hellwig To: Anshuman Khandual Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, hch@infradead.org, akpm@linux-foundation.org Subject: Re: [RFC V1 02/31] mm/mmap: Clarify protection_map[] indices Message-ID: References: <1643029028-12710-1-git-send-email-anshuman.khandual@arm.com> <1643029028-12710-3-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1643029028-12710-3-git-send-email-anshuman.khandual@arm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: tgq1ua5jk8hr6fzf7njx34z61mh83kic X-Rspam-User: nil Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=tR1PVeVh; spf=none (imf30.hostedemail.com: domain of BATV+2ed252487af0c8944991+6730+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2ed252487af0c8944991+6730+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: BBD8480004 X-HE-Tag: 1643181401-645691 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000109, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + [VM_NONE] = __P000, > + [VM_READ] = __P001, > + [VM_WRITE] = __P010, > + [VM_READ|VM_WRITE] = __P011, > + [VM_EXEC] = __P100, > + [VM_EXEC|VM_READ] = __P101, > + [VM_EXEC|VM_WRITE] = __P110, > + [VM_EXEC|VM_READ|VM_WRITE] = __P111, > + [VM_SHARED] = __S000, > + [VM_SHARED|VM_READ] = __S001, > + [VM_SHARED|VM_WRITE] = __S010, > + [VM_SHARED|VM_READ|VM_WRITE] = __S011, > + [VM_SHARED|VM_EXEC] = __S100, > + [VM_SHARED|VM_READ|VM_EXEC] = __S101, > + [VM_SHARED|VM_WRITE|VM_EXEC] = __S110, > + [VM_SHARED|VM_READ|VM_WRITE|VM_EXEC] = __S111 Please add whitespaces around the | operators. Otherwise looks good: Reviewed-by: Christoph Hellwig