From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Michal Hocko <mhocko@suse.com>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Vladimir Davydov" <vdavydov.dev@gmail.com>,
"Waiman Long" <longman@redhat.com>
Subject: Re: [PATCH 1/4] mm/memcg: Disable threshold event handlers on PREEMPT_RT
Date: Wed, 26 Jan 2022 15:45:20 +0100 [thread overview]
Message-ID: <YfFegDwQSm9v2Qcu@linutronix.de> (raw)
In-Reply-To: <YfFddqkAhd1YKqX9@dhcp22.suse.cz>
On 2022-01-26 15:40:54 [+0100], Michal Hocko wrote:
> I still support this approach but the patch is much larger than
> necessary. The code moving shouldn't be really necessary and a simple
> "do not allow" to set any thresholds or soft limit should be good
> enough.
>
> While in general it is better to disable the unreachable code I do not
> think this is worth the code churn here.
I got the "defined but not used" warnings by the compiler after I
disabled the two functions. Then I moved everything to one code block to
avoid the multiple ifdefs.
If that is not good, let me think of something else…
Sebastian
next prev parent reply other threads:[~2022-01-26 14:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 16:43 [PATCH 0/4] mm/memcg: Address PREEMPT_RT problems instead of disabling it Sebastian Andrzej Siewior
2022-01-25 16:43 ` [PATCH 1/4] mm/memcg: Disable threshold event handlers on PREEMPT_RT Sebastian Andrzej Siewior
2022-01-26 14:40 ` Michal Hocko
2022-01-26 14:45 ` Sebastian Andrzej Siewior [this message]
2022-01-26 15:04 ` Michal Koutný
2022-01-27 13:36 ` Sebastian Andrzej Siewior
2022-01-26 15:21 ` Michal Hocko
2022-01-25 16:43 ` [PATCH 2/4] mm/memcg: Protect per-CPU counter by disabling preemption on PREEMPT_RT where needed Sebastian Andrzej Siewior
2022-01-26 10:06 ` Vlastimil Babka
2022-01-26 11:24 ` Sebastian Andrzej Siewior
2022-01-26 14:56 ` Michal Hocko
2022-01-25 16:43 ` [PATCH 3/4] mm/memcg: Add a local_lock_t for IRQ and TASK object Sebastian Andrzej Siewior
2022-01-26 15:20 ` Michal Hocko
2022-01-27 11:53 ` Sebastian Andrzej Siewior
2022-02-01 12:04 ` Michal Hocko
2022-02-01 12:11 ` Sebastian Andrzej Siewior
2022-02-01 15:29 ` Michal Hocko
2022-02-03 9:54 ` Sebastian Andrzej Siewior
2022-02-03 10:09 ` Michal Hocko
2022-02-03 11:09 ` Sebastian Andrzej Siewior
2022-02-08 17:58 ` Shakeel Butt
2022-02-09 9:17 ` Michal Hocko
2022-01-26 16:57 ` Vlastimil Babka
2022-01-31 15:06 ` Sebastian Andrzej Siewior
2022-02-03 16:01 ` Vlastimil Babka
2022-02-08 17:17 ` Sebastian Andrzej Siewior
2022-02-08 17:28 ` Michal Hocko
2022-02-09 1:48 ` [mm/memcg] 86895e1e85: WARNING:possible_circular_locking_dependency_detected kernel test robot
2022-01-25 16:43 ` [PATCH 4/4] mm/memcg: Allow the task_obj optimization only on non-PREEMPTIBLE kernels Sebastian Andrzej Siewior
2022-01-25 23:21 ` [PATCH 0/4] mm/memcg: Address PREEMPT_RT problems instead of disabling it Andrew Morton
2022-01-26 7:30 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfFegDwQSm9v2Qcu@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mhocko@suse.com \
--cc=mkoutny@suse.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).