linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm/mmzone.h: remove unused macros
@ 2022-01-27  9:32 Miaohe Lin
  2022-01-27  9:55 ` David Hildenbrand
  2022-01-27 12:44 ` Mike Rapoport
  0 siblings, 2 replies; 3+ messages in thread
From: Miaohe Lin @ 2022-01-27  9:32 UTC (permalink / raw)
  To: akpm; +Cc: linux-mm, linux-kernel, linmiaohe

Remove pgdat_page_nr, nid_page_nr and NODE_MEM_MAP. They are unused now.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 include/linux/mmzone.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index aed44e9b5d89..6c004256d943 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -920,12 +920,6 @@ typedef struct pglist_data {
 
 #define node_present_pages(nid)	(NODE_DATA(nid)->node_present_pages)
 #define node_spanned_pages(nid)	(NODE_DATA(nid)->node_spanned_pages)
-#ifdef CONFIG_FLATMEM
-#define pgdat_page_nr(pgdat, pagenr)	((pgdat)->node_mem_map + (pagenr))
-#else
-#define pgdat_page_nr(pgdat, pagenr)	pfn_to_page((pgdat)->node_start_pfn + (pagenr))
-#endif
-#define nid_page_nr(nid, pagenr) 	pgdat_page_nr(NODE_DATA(nid),(pagenr))
 
 #define node_start_pfn(nid)	(NODE_DATA(nid)->node_start_pfn)
 #define node_end_pfn(nid) pgdat_end_pfn(NODE_DATA(nid))
@@ -1101,7 +1095,6 @@ static inline struct pglist_data *NODE_DATA(int nid)
 {
 	return &contig_page_data;
 }
-#define NODE_MEM_MAP(nid)	mem_map
 
 #else /* CONFIG_NUMA */
 
-- 
2.23.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] mm/mmzone.h: remove unused macros
  2022-01-27  9:32 [PATCH] mm/mmzone.h: remove unused macros Miaohe Lin
@ 2022-01-27  9:55 ` David Hildenbrand
  2022-01-27 12:44 ` Mike Rapoport
  1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2022-01-27  9:55 UTC (permalink / raw)
  To: Miaohe Lin, akpm; +Cc: linux-mm, linux-kernel

On 27.01.22 10:32, Miaohe Lin wrote:
> Remove pgdat_page_nr, nid_page_nr and NODE_MEM_MAP. They are unused now.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>  include/linux/mmzone.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index aed44e9b5d89..6c004256d943 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -920,12 +920,6 @@ typedef struct pglist_data {
>  
>  #define node_present_pages(nid)	(NODE_DATA(nid)->node_present_pages)
>  #define node_spanned_pages(nid)	(NODE_DATA(nid)->node_spanned_pages)
> -#ifdef CONFIG_FLATMEM
> -#define pgdat_page_nr(pgdat, pagenr)	((pgdat)->node_mem_map + (pagenr))
> -#else
> -#define pgdat_page_nr(pgdat, pagenr)	pfn_to_page((pgdat)->node_start_pfn + (pagenr))
> -#endif
> -#define nid_page_nr(nid, pagenr) 	pgdat_page_nr(NODE_DATA(nid),(pagenr))
>  
>  #define node_start_pfn(nid)	(NODE_DATA(nid)->node_start_pfn)
>  #define node_end_pfn(nid) pgdat_end_pfn(NODE_DATA(nid))
> @@ -1101,7 +1095,6 @@ static inline struct pglist_data *NODE_DATA(int nid)
>  {
>  	return &contig_page_data;
>  }
> -#define NODE_MEM_MAP(nid)	mem_map
>  
>  #else /* CONFIG_NUMA */
>  

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mm/mmzone.h: remove unused macros
  2022-01-27  9:32 [PATCH] mm/mmzone.h: remove unused macros Miaohe Lin
  2022-01-27  9:55 ` David Hildenbrand
@ 2022-01-27 12:44 ` Mike Rapoport
  1 sibling, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2022-01-27 12:44 UTC (permalink / raw)
  To: Miaohe Lin; +Cc: akpm, linux-mm, linux-kernel

On Thu, Jan 27, 2022 at 05:32:10PM +0800, Miaohe Lin wrote:
> Remove pgdat_page_nr, nid_page_nr and NODE_MEM_MAP. They are unused now.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>

> ---
>  include/linux/mmzone.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index aed44e9b5d89..6c004256d943 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -920,12 +920,6 @@ typedef struct pglist_data {
>  
>  #define node_present_pages(nid)	(NODE_DATA(nid)->node_present_pages)
>  #define node_spanned_pages(nid)	(NODE_DATA(nid)->node_spanned_pages)
> -#ifdef CONFIG_FLATMEM
> -#define pgdat_page_nr(pgdat, pagenr)	((pgdat)->node_mem_map + (pagenr))
> -#else
> -#define pgdat_page_nr(pgdat, pagenr)	pfn_to_page((pgdat)->node_start_pfn + (pagenr))
> -#endif
> -#define nid_page_nr(nid, pagenr) 	pgdat_page_nr(NODE_DATA(nid),(pagenr))
>  
>  #define node_start_pfn(nid)	(NODE_DATA(nid)->node_start_pfn)
>  #define node_end_pfn(nid) pgdat_end_pfn(NODE_DATA(nid))
> @@ -1101,7 +1095,6 @@ static inline struct pglist_data *NODE_DATA(int nid)
>  {
>  	return &contig_page_data;
>  }
> -#define NODE_MEM_MAP(nid)	mem_map
>  
>  #else /* CONFIG_NUMA */
>  
> -- 
> 2.23.0
> 
> 

-- 
Sincerely yours,
Mike.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-27 12:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-27  9:32 [PATCH] mm/mmzone.h: remove unused macros Miaohe Lin
2022-01-27  9:55 ` David Hildenbrand
2022-01-27 12:44 ` Mike Rapoport

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).