From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89D70C433F5 for ; Thu, 27 Jan 2022 13:54:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 191436B008C; Thu, 27 Jan 2022 08:54:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 141196B0093; Thu, 27 Jan 2022 08:54:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02F126B0095; Thu, 27 Jan 2022 08:54:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id E53A56B008C for ; Thu, 27 Jan 2022 08:54:37 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A7662181B0495 for ; Thu, 27 Jan 2022 13:54:37 +0000 (UTC) X-FDA: 79076212194.22.3029CB1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id E7A03140006 for ; Thu, 27 Jan 2022 13:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+zbTlD7Vb3Z4rFPtDsfUIAfz+fZe4eO2NmvnUWDIogk=; b=o9Voac63tzeMidBk9tHh5fshN8 BzPwaUCjF0ZBzarWVolSwPhQBwqZJCHWbFtYgVgPyBxBXvugjZyYig6AHMLZuMXBTIVly+Q8WnsD1 s+wL0ulOpVCurNRIc1CQbk5ZLRAmp7BeVksl3bEoTTAx94TE7s7tfuE+lB5pk0CU09C38hmk7xXa0 Aqk0VW7YnjkU1eB4Aiym2I+5E5xKEVhfuL2zFnwsfrPTDtSgvew6Z0FisYRhvb5twAS5xRv4kX0p5 4lHA8Ism/DMfGVDIwusK+peHAMG3l3jkg3vHRmr4ef3ca2LEQ+xspqZQbtH2ui0jzMcBrdEoRPhIl hEKcm1vw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nD5EQ-005Hyl-FD; Thu, 27 Jan 2022 13:54:34 +0000 Date: Thu, 27 Jan 2022 13:54:34 +0000 From: Matthew Wilcox To: Karolina Drobnik Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mike.rapoport@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/16] tools/include: Add _RET_IP_ and math definitions to kernel.h Message-ID: References: <5baa036aadb6436c7c36589ce591baaf827aec0b.1643206612.git.karolinadrobnik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5baa036aadb6436c7c36589ce591baaf827aec0b.1643206612.git.karolinadrobnik@gmail.com> X-Rspam-User: nil X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E7A03140006 X-Stat-Signature: stdejo5qeie9n1x3yxmufbfz7sn8wjop Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=o9Voac63; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1643291676-301825 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002048, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 27, 2022 at 02:21:21PM +0100, Karolina Drobnik wrote: > Add max_t, min_t and clamp functions, together with _RET_IP_ > definition, so they can be used in testing. Rather than adding our own definitions of min/max/clamp, have you considered using #include "../../../include/linux/minmax.h"? In my experience reusing this kind of "leaf" header works out better than duplicating it.