From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31223C433F5 for ; Thu, 27 Jan 2022 14:09:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE00B6B009D; Thu, 27 Jan 2022 09:09:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B8F4E6B009F; Thu, 27 Jan 2022 09:09:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A591E6B00A0; Thu, 27 Jan 2022 09:09:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay037.a.hostedemail.com [64.99.140.37]) by kanga.kvack.org (Postfix) with ESMTP id 4FAA26B009D for ; Thu, 27 Jan 2022 09:09:20 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2607F22246 for ; Thu, 27 Jan 2022 14:09:18 +0000 (UTC) X-FDA: 79076249196.02.CE539FD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 84D1EA0011 for ; Thu, 27 Jan 2022 14:09:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=59JKSkvc74DWwVkjK+v6CkrZWKoKtEZ3D8hogGvO6Ww=; b=tppngXPoOUdNU+dDbRM7RdxtuE XW0L5l80ljCLF6VtwnI2R3ABbRV5AA6yDo1K6SD49ShJrzDkMcqnL7BL9jzfeDK27gzsdFYo0Ytt3 WitpVqTRilKwmCqwLXw2dcC6YYZW59Xb5bS0vILDqNWpjTMpUNAC/7nvRH0b3aItnQoVpXNEpVhsn KqUjM6zU7o9ra6IEnTnIsrDHJaiokqTAqZ7Z/Usch/woP4abU6HQrgXDka9U4DpXhrkNMYjX1WUS0 AMgt8a2K622Xrh1lp77YYca99OlPaqMXladND1C4BU1OtSCNzTioVQK8Kx0skBsBmio8RRNL94rlN PCPgtrQw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nD5SS-005If6-Oh; Thu, 27 Jan 2022 14:09:04 +0000 Date: Thu, 27 Jan 2022 14:09:04 +0000 From: Matthew Wilcox To: Karolina Drobnik Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mike.rapoport@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/16] tools/include: Add io.h stub Message-ID: References: <2d9aa000afe81b45157617664134b871207c2067.1643206612.git.karolinadrobnik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d9aa000afe81b45157617664134b871207c2067.1643206612.git.karolinadrobnik@gmail.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 84D1EA0011 X-Stat-Signature: kfrrngrfc4rd1kmrb7wawenhwf4sht8i Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tppngXPo; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: nil X-HE-Tag: 1643292555-910071 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000110, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 27, 2022 at 02:21:25PM +0100, Karolina Drobnik wrote: > Add a dummy io.h header. Rather begs the question of what memblock.c needs from linux/io.h. Wouldn't it be better to: +++ b/mm/memblock.c @@ -18,7 +18,6 @@ #include #include -#include #include "internal.h" (allmodconfig on x86-64 builds fine with this; I have not done an extended sweep of other arches / build options).