From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42EE5C433EF for ; Mon, 31 Jan 2022 14:45:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA8FF6B00AD; Mon, 31 Jan 2022 09:45:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A58946B00AF; Mon, 31 Jan 2022 09:45:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96E4D6B00B0; Mon, 31 Jan 2022 09:45:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0184.hostedemail.com [216.40.44.184]) by kanga.kvack.org (Postfix) with ESMTP id 885ED6B00AD for ; Mon, 31 Jan 2022 09:45:06 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 40CF995CA5 for ; Mon, 31 Jan 2022 14:45:06 +0000 (UTC) X-FDA: 79090854612.11.B4C0E43 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf31.hostedemail.com (Postfix) with ESMTP id BC8D020008 for ; Mon, 31 Jan 2022 14:45:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=S37hV5LKYMZr1FwdKbRBbnns+EHid9XjyHNmHg+zn0s=; b=T67AodPbh6KjEXf58AyRu2Mb9k Ja+cbgWubfMKArkw4GvrZ9bhtm5QFzrcusJg2M5hdW7/TnNDHDIFDLnXqo/zlv0o7+vNa0MEXbKbV gn0Kbzbm3yfdMO4sXhjpVlYY2kNCCE0FBRaaTRQThzFifyvARd8MrOTtiG0e7wGpBRB9VG1F/kccB 0pmOEDERa1yMdETLCBl4+fBNvBd7wk/RLUXDpj46b4ppYCyVgv72Q2Vq38p6BURmRfm9/VGKQeXhQ /LVSXR00CgQL++0RFinoAjEtt/cPws6pjPE0lDzE5BiqQsMTfmCNc32hjC4E/1QWLsgQ9Cnl2teoP zNZWi0cw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEXvL-009z9U-6c; Mon, 31 Jan 2022 14:44:55 +0000 Date: Mon, 31 Jan 2022 14:44:55 +0000 From: Matthew Wilcox To: Michel Lespinasse Cc: Linux-MM , linux-kernel@vger.kernel.org, Andrew Morton , kernel-team@fb.com, Laurent Dufour , Jerome Glisse , Peter Zijlstra , Michal Hocko , Vlastimil Babka , Davidlohr Bueso , Liam Howlett , Rik van Riel , Paul McKenney , Song Liu , Suren Baghdasaryan , Minchan Kim , Joel Fernandes , David Rientjes , Axel Rasmussen , Andy Lutomirski Subject: Re: [PATCH v2 12/35] mm: separate mmap locked assertion from find_vma Message-ID: References: <20220128131006.67712-1-michel@lespinasse.org> <20220128131006.67712-13-michel@lespinasse.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220128131006.67712-13-michel@lespinasse.org> Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T67AodPb; spf=none (imf31.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspam-User: nil X-Rspamd-Queue-Id: BC8D020008 X-Stat-Signature: tu8h3xsxiebnj7jf7kakjk9r7uq86joc X-Rspamd-Server: rspam12 X-HE-Tag: 1643640305-680666 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 28, 2022 at 05:09:43AM -0800, Michel Lespinasse wrote: > This adds a new __find_vma() function, which implements find_vma minus > the mmap_assert_locked() assertion. > > find_vma() is then implemented as an inline wrapper around __find_vma(). You might like to take inspiration from the maple tree patches where we assert that either the RCU lock is held or the mmap_lock is held.