From: Matthew Wilcox <willy@infradead.org>
To: Joao Martins <joao.m.martins@oracle.com>
Cc: Jane Chu <jane.chu@oracle.com>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC] Missing compound_head() in memory-failure
Date: Tue, 1 Feb 2022 02:34:24 +0000 [thread overview]
Message-ID: <YficMPAQBS4PZ8/T@casper.infradead.org> (raw)
In-Reply-To: <30a327fd-ae49-7412-ef77-9ec19480626e@oracle.com>
On Mon, Jan 31, 2022 at 08:54:39PM +0000, Joao Martins wrote:
>
>
> On 1/31/22 20:29, Matthew Wilcox wrote:
> > Unless I am mistaken, you have to pass the compound head of the page
> > which has the error to collect_procs(). Am I mistaken?
> >
> -rc2 already has a fix for it:
>
> https://lore.kernel.org/linux-mm/20220129021420.PgBIZm-q9%25akpm@linux-foundation.org/
>
> Earlier in that function there's a:
>
> page = compound_head(page);
>
> So the @page passed to collect_procs() already is a head page.
Well, that'll teach me to be two days behind on Linus' tree ;-)
next prev parent reply other threads:[~2022-02-01 2:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 20:29 [RFC] Missing compound_head() in memory-failure Matthew Wilcox
2022-01-31 20:54 ` Joao Martins
2022-02-01 2:34 ` Matthew Wilcox [this message]
2022-02-01 15:46 ` Matthew Wilcox
2022-02-01 16:01 ` Joao Martins
2022-02-01 17:40 ` Joao Martins
2022-02-01 17:47 ` Matthew Wilcox
2022-02-01 18:34 ` Joao Martins
2022-02-01 21:11 ` Jane Chu
2022-02-01 22:04 ` Joao Martins
2022-02-01 22:20 ` Dan Williams
2022-02-01 23:04 ` Jane Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YficMPAQBS4PZ8/T@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jane.chu@oracle.com \
--cc=joao.m.martins@oracle.com \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).