From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D03BC433FE for ; Tue, 1 Feb 2022 15:26:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CC2C6B01F2; Tue, 1 Feb 2022 10:26:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 97AA96B01F3; Tue, 1 Feb 2022 10:26:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 841F16B01F4; Tue, 1 Feb 2022 10:26:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0122.hostedemail.com [216.40.44.122]) by kanga.kvack.org (Postfix) with ESMTP id 76E0C6B01F2 for ; Tue, 1 Feb 2022 10:26:39 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2F0A681544A8 for ; Tue, 1 Feb 2022 15:26:39 +0000 (UTC) X-FDA: 79094588118.09.B11FC53 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id BAA9580005 for ; Tue, 1 Feb 2022 15:26:38 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B47CC61510; Tue, 1 Feb 2022 15:26:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C32BC340EB; Tue, 1 Feb 2022 15:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643729197; bh=D+RrHXUNVvIfZXzq/hDFYNc82WJYpI5xTqKhv7Ezh54=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ne613kzsv+qtB9aIL4yFk9meuhxVcaPqpGRMdgsZI+Kn/RWnKft7Ts1Uqq1FdcF7n vpuhBMoaQ7WxjmG7FZ+vhCtJ3AljpEJLiH31ixR+nM+n94JYowaawJ/5e0c2kvy0PH CUyAG4JHxeHviwMiRoiV/zVCwHeo15D394w4wPCMs51JO6/BXjpfS+wkgH1fW7pUlv tXmT9S6YOorBCNVYL+/lVQ+7YaVyxbsIAkXU56OG3W5fhYiwXw0Er2sNS0Eh0oLmZ3 /kU+7YkNtSK9fc/tPMzTvRhAK8lj3W27N8jcqdkmC3HLEhJhtalqLAMJHYKmgvl417 hkgC3IrF9CpXw== Date: Tue, 1 Feb 2022 17:26:29 +0200 From: Mike Rapoport To: Karolina Drobnik Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH] memblock: Remove unused io.h include Message-ID: References: <20220131121723.72395-1-karolinadrobnik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220131121723.72395-1-karolinadrobnik@gmail.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BAA9580005 X-Stat-Signature: adztbce8pss3w1857cphwacci3m6y9jr Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ne613kzs; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Rspam-User: nil X-HE-Tag: 1643729198-187349 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Karolina, On Mon, Jan 31, 2022 at 01:17:23PM +0100, Karolina Drobnik wrote: > Memblock does not use anything from io.h, remove the include. As Matthew pointed out [1], many architectures put their definition of virt_to_phys() in asm/io.h, e.g. arch/powerpc/include/asm/io.h:#define virt_to_phys virt_to_phys arch/sh/include/asm/io.h:#define virt_to_phys(address) ((unsigned long)(address)) arch/x86/include/asm/io.h:#define virt_to_phys virt_to_phys which means memblock needs this header for declaration of virt_to_phys(). Although it is included indirectly, let's keep it for now. [1] https://lore.kernel.org/all/YfbQlMyohx31FhSW@casper.infradead.org/ > Suggested-by: Matthew Wilcox (Oracle) > Signed-off-by: Karolina Drobnik > --- > mm/memblock.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 1018e50566f3..4ee190b3f026 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -18,7 +18,6 @@ > #include > > #include > -#include > > #include "internal.h" > > -- > 2.30.2 > -- Sincerely yours, Mike.