From: Sean Young <sean@mess.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
kernel test robot <oliver.sang@intel.com>,
Alexei Starovoitov <ast@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
lkp@lists.01.org, kbuild test robot <lkp@intel.com>
Subject: Re: [tools headers UAPI] e2bcbd7769: kernel-selftests.ir.make_fail
Date: Tue, 1 Feb 2022 16:51:39 +0000 [thread overview]
Message-ID: <YfllGx5PRMT9tDDc@gofer.mess.org> (raw)
In-Reply-To: <347bae9f-f775-4976-3d27-b0c725211d78@linuxfoundation.org>
On Fri, Jan 28, 2022 at 10:57:35AM -0700, Shuah Khan wrote:
> On 1/28/22 10:38 AM, Sean Young wrote:
> > On Fri, Jan 28, 2022 at 10:27:52AM -0700, Shuah Khan wrote:
> > > On 1/28/22 9:49 AM, Alexei Starovoitov wrote:
> > > > On Fri, Jan 28, 2022 at 1:32 AM Sean Young <sean@mess.org> wrote:
> > > > >
> > >
> > > > > > ir_loopback.c: In function ‘main’:
> > > > > > ir_loopback.c:147:20: error: ‘RC_PROTO_RCMM32’ undeclared (first use in this function); did you mean ‘RC_PROTO_RC6_MCE’?
> > > > > > if (rc_proto == RC_PROTO_RCMM32 &&
> > > > > > ^~~~~~~~~~~~~~~
> > > > > > RC_PROTO_RC6_MCE
> > > > >
> > > > > So this commit removes the copy of lirc.h from tools/include/uapi/linux/lirc.h,
> > > > > so now the test uses /usr/include/linux/lirc.h. It appears that this file
> > > > > does not have RC_PROTO_RCMM32 defined on this system, which means it is a
> > > > > kernel header from v5.1 or earlier (this was added in commit
> > > > > 721074b03411327e7bf41555d4cc7c18f49313f7).
> > > > >
> > > > > It looks like this machine is redhat 8.3, which ships with kernel 4.18.
> > > > >
> > > > > I guess my change was far too optimistic; I had no ideal enterprise kernels
> > > > > were so ancient.
>
> > Hi Shuah,
> >
> > I was thinking along the same lines, however RC_PROTO_RCMM32 is an enum
> > value so a pre-processor #ifdef is not going to work. At the moment I haven't
> > had any bright ideas other than doing a `#define RC_PROTO_RCMM32 26` at the
> > top of the file.
> >
>
> One more idea. Let's see if this works. Check for RC_PROTO_MAX if it existed
> before this commit that RC_PROTO_RCMM32, you could define RC_PROTO_RCMM32
> conditionally in the test scope. If not let's go woth your plan of defining
> it at the top with some info.
Good idea, this works! patch in another reply in this thread.
Sorry about the mess, thanks for the suggestions.
Sean
next prev parent reply other threads:[~2022-02-01 16:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 7:53 [tools headers UAPI] e2bcbd7769: kernel-selftests.ir.make_fail kernel test robot
2022-01-28 9:31 ` Sean Young
2022-01-28 16:49 ` Alexei Starovoitov
2022-01-28 17:27 ` Shuah Khan
2022-01-28 17:38 ` Sean Young
2022-01-28 17:57 ` Shuah Khan
2022-02-01 16:51 ` Sean Young [this message]
2022-02-01 16:53 ` [PATCH] selftests/ir: fix build with ancient kernel headers Sean Young
2022-02-01 16:58 ` Matthew Wilcox
2022-02-01 17:10 ` Sean Young
2022-02-01 17:42 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfllGx5PRMT9tDDc@gofer.mess.org \
--to=sean@mess.org \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=oliver.sang@intel.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).