From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AD63C433EF for ; Tue, 1 Feb 2022 16:51:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9677B6B0150; Tue, 1 Feb 2022 11:51:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9179A8D006D; Tue, 1 Feb 2022 11:51:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DE656B0152; Tue, 1 Feb 2022 11:51:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id 6BA096B0150 for ; Tue, 1 Feb 2022 11:51:42 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2360118258253 for ; Tue, 1 Feb 2022 16:51:42 +0000 (UTC) X-FDA: 79094802444.05.F28E4A7 Received: from gofer.mess.org (gofer.mess.org [88.97.38.141]) by imf07.hostedemail.com (Postfix) with ESMTP id 9407340002 for ; Tue, 1 Feb 2022 16:51:41 +0000 (UTC) Received: by gofer.mess.org (Postfix, from userid 1000) id D904F101BFE; Tue, 1 Feb 2022 16:51:39 +0000 (UTC) Date: Tue, 1 Feb 2022 16:51:39 +0000 From: Sean Young To: Shuah Khan Cc: Alexei Starovoitov , kernel test robot , Alexei Starovoitov , LKML , Linux Memory Management List , lkp@lists.01.org, kbuild test robot Subject: Re: [tools headers UAPI] e2bcbd7769: kernel-selftests.ir.make_fail Message-ID: References: <20220128075346.GG8421@xsang-OptiPlex-9020> <347bae9f-f775-4976-3d27-b0c725211d78@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <347bae9f-f775-4976-3d27-b0c725211d78@linuxfoundation.org> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 9407340002 X-Stat-Signature: j4njb3d4g4u9bezs6rjdhz889zm15dft Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of sean@mess.org designates 88.97.38.141 as permitted sender) smtp.mailfrom=sean@mess.org; dmarc=pass (policy=none) header.from=mess.org X-Rspam-User: nil X-HE-Tag: 1643734301-73325 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 28, 2022 at 10:57:35AM -0700, Shuah Khan wrote: > On 1/28/22 10:38 AM, Sean Young wrote: > > On Fri, Jan 28, 2022 at 10:27:52AM -0700, Shuah Khan wrote: > > > On 1/28/22 9:49 AM, Alexei Starovoitov wrote: > > > > On Fri, Jan 28, 2022 at 1:32 AM Sean Young wrote: > > > > >=20 > > >=20 > > > > > > ir_loopback.c: In function =E2=80=98main=E2=80=99: > > > > > > ir_loopback.c:147:20: error: =E2=80=98RC_PROTO_RCMM32=E2=80=99= undeclared (first use in this function); did you mean =E2=80=98RC_PROTO_= RC6_MCE=E2=80=99? > > > > > > if (rc_proto =3D=3D RC_PROTO_RCMM32 && > > > > > > ^~~~~~~~~~~~~~~ > > > > > > RC_PROTO_RC6_MCE > > > > >=20 > > > > > So this commit removes the copy of lirc.h from tools/include/ua= pi/linux/lirc.h, > > > > > so now the test uses /usr/include/linux/lirc.h. It appears that= this file > > > > > does not have RC_PROTO_RCMM32 defined on this system, which mea= ns it is a > > > > > kernel header from v5.1 or earlier (this was added in commit > > > > > 721074b03411327e7bf41555d4cc7c18f49313f7). > > > > >=20 > > > > > It looks like this machine is redhat 8.3, which ships with kern= el 4.18. > > > > >=20 > > > > > I guess my change was far too optimistic; I had no ideal enterp= rise kernels > > > > > were so ancient. >=20 > > Hi Shuah, > >=20 > > I was thinking along the same lines, however RC_PROTO_RCMM32 is an en= um > > value so a pre-processor #ifdef is not going to work. At the moment I= haven't > > had any bright ideas other than doing a `#define RC_PROTO_RCMM32 26` = at the > > top of the file. > >=20 >=20 > One more idea. Let's see if this works. Check for RC_PROTO_MAX if it ex= isted > before this commit that RC_PROTO_RCMM32, you could define RC_PROTO_RCMM= 32 > conditionally in the test scope. If not let's go woth your plan of defi= ning > it at the top with some info. Good idea, this works! patch in another reply in this thread. Sorry about the mess, thanks for the suggestions. Sean