From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94397C433F5 for ; Sun, 6 Feb 2022 18:13:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C42D6B0071; Sun, 6 Feb 2022 13:13:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9737E6B0072; Sun, 6 Feb 2022 13:13:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8638D6B0073; Sun, 6 Feb 2022 13:13:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 7B0446B0071 for ; Sun, 6 Feb 2022 13:13:21 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 2ACEF80793 for ; Sun, 6 Feb 2022 18:13:21 +0000 (UTC) X-FDA: 79113152202.03.437DC2E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id B4DD3120003 for ; Sun, 6 Feb 2022 18:13:20 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BD2F86106D; Sun, 6 Feb 2022 18:13:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B2E9C340EF; Sun, 6 Feb 2022 18:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644171199; bh=NjhEy8t/LIGmsUj5Jg4adnjliOrIOEvCocma09gYM8A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=suno0EJ5R6M6zvnM9tsTiiZfhFXLudtB1aLQ9AAZ23+m6B38WfJIKOwaJBrgjMhRz oroExj8Yd5NZGBOxF4qgaRQa0qSiTAoHf8zCPhW7CTKsucPrh8d34Zp6rB6i+tlnXc zlAad3LhQANo6PqtnT6ym9Yj/bms/Q1YP0bU50gpKjHkQsVsP7xxU4fwhbf7Zt2gJw 2cYq9Xo/Ih4PbxgfSwYWbp0WYewrMtlJ0hA2xi3q21sPkJQvUHLXFUw4pUH3Vd6jR/ hMEDrqDFlVKMmWKzhcdBVYt6KkzFmddzgMLCJMe+hI1lNXRhMJ+KbxeWxk/mZWlIV5 4dvOpZ8Sxgrzw== Date: Sun, 6 Feb 2022 20:13:11 +0200 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 41/75] hexagon: Add pmd_pfn() Message-ID: References: <20220204195852.1751729-1-willy@infradead.org> <20220204195852.1751729-42-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220204195852.1751729-42-willy@infradead.org> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B4DD3120003 X-Stat-Signature: nnudk5h6rdzk4kcg5m6cdtmb75kaerh3 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=suno0EJ5; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Rspam-User: nil X-HE-Tag: 1644171200-560644 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 04, 2022 at 07:58:18PM +0000, Matthew Wilcox (Oracle) wrote: > I need to use this function in common code, so define it for hexagon. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > arch/hexagon/include/asm/pgtable.h | 3 ++- Why hexagon out of all architectures? What about m68k, nios2, nds32 etc? > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/hexagon/include/asm/pgtable.h b/arch/hexagon/include/asm/pgtable.h > index 18cd6ea9ab23..87e96463ccd6 100644 > --- a/arch/hexagon/include/asm/pgtable.h > +++ b/arch/hexagon/include/asm/pgtable.h > @@ -235,10 +235,11 @@ static inline int pmd_bad(pmd_t pmd) > return 0; > } > > +#define pmd_pfn(pmd) (pmd_val(pmd) >> PAGE_SHIFT) I'd put it in include/linux/pgtable.h inside #ifndef pmd_pfn > /* > * pmd_page - converts a PMD entry to a page pointer > */ > -#define pmd_page(pmd) (pfn_to_page(pmd_val(pmd) >> PAGE_SHIFT)) > +#define pmd_page(pmd) (pfn_to_page(pmd_pfn(pmd))) > > /** > * pte_none - check if pte is mapped > -- > 2.34.1 > > -- Sincerely yours, Mike.