From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E9F8C433F5 for ; Mon, 7 Feb 2022 07:49:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 081D86B0075; Mon, 7 Feb 2022 02:49:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 031D66B0078; Mon, 7 Feb 2022 02:49:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E64026B007B; Mon, 7 Feb 2022 02:49:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by kanga.kvack.org (Postfix) with ESMTP id D93C36B0075 for ; Mon, 7 Feb 2022 02:49:44 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9CB841816C8CA for ; Mon, 7 Feb 2022 07:49:44 +0000 (UTC) X-FDA: 79115209488.29.653462F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id 55E4840003 for ; Mon, 7 Feb 2022 07:49:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UcF3TmO8gMJDNho3UCi/3NRz3Ku+zKXzuhi1ha055vc=; b=wXsjzM9RYNVa28neM6wAn0MYUd LJ9GAf4gWX9pIW17MA8OGRW7q9AKWfFqMM9OK3hFXlS3rTjRDn1f7wh7Qo2aJPEH3BzaxFFv3uUi0 RFvPOd3s6cmj4AN1zPosjSTEpQ1KkgjpD82FI7MxRs3aK149DApCPq/dGf2lmYHeSPdP3Cb5m6LjJ FSe2tXIH31HoidckH8WyLMEshhuiEEMrtzlLpTuvxMyHwbyEfd3pWsLwf3e/5yWmSvClVJuI1BCY2 HdSu6hsGrLRdXKgzOlf6XFUAq5UJYzqKeA3zRM5ije4LcTwArZvkDi2TZ3ncLOeYGYo32ajlk0bXT cQOcXhog==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nGymN-009Fo5-Ca; Mon, 07 Feb 2022 07:49:43 +0000 Date: Sun, 6 Feb 2022 23:49:43 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 30/75] mm/memcg: Convert mem_cgroup_swapout() to take a folio Message-ID: References: <20220204195852.1751729-1-willy@infradead.org> <20220204195852.1751729-31-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220204195852.1751729-31-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 55E4840003 X-Stat-Signature: 38g5bh9xtq3i3kffqwyqqh7wwba41jum Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=wXsjzM9R; dmarc=none; spf=none (imf17.hostedemail.com: domain of BATV+0c52a814cb66561dc7fc+6742+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0c52a814cb66561dc7fc+6742+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: nil X-HE-Tag: 1644220184-753479 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 04, 2022 at 07:58:07PM +0000, Matthew Wilcox (Oracle) wrote: > #ifdef CONFIG_MEMCG_SWAP > -extern void mem_cgroup_swapout(struct page *page, swp_entry_t entry); > +extern void mem_cgroup_swapout(struct folio *folio, swp_entry_t entry); Might be worth to drop the extern while you're at it. Otherwise looks good: Reviewed-by: Christoph Hellwig