Re: [PATCH 21/22] mmc: wbsd: Use dma_alloc_noncoherent() for dma buffer

Christoph Hellwig
2022-02-19T07:17:36Z

On Sat, Feb 19, 2022 at 08:52:20AM +0800, Baoquan He wrote:
> if (request_dma(dma, DRIVER_NAME))
> goto err;
>
> + dma_set_mask_and_coherent(mmc_dev(host->mmc), DMA_BIT_MASK(24));

This also sets the streaming mask, but the driver doesn't seem to make
use of that. Please document it in the commit log.

Also setting smaller than 32 bit masks can fail, so this should have
error handling.