From: Luis Chamberlain <mcgrof@kernel.org>
To: tangmeng <tangmeng@uniontech.com>
Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
keescook@chromium.org, yzaikin@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
nizhen@uniontech.com, zhanglianjie@uniontech.com,
nixiaoming@huawei.com
Subject: Re: [PATCH v2 10/11] fs/drop_caches: move drop_caches sysctls to its own file
Date: Sat, 26 Feb 2022 13:02:19 -0800 [thread overview]
Message-ID: <YhqVW972rnF5L22U@bombadil.infradead.org> (raw)
In-Reply-To: <20220221061018.10472-1-tangmeng@uniontech.com>
On Mon, Feb 21, 2022 at 02:10:18PM +0800, tangmeng wrote:
> kernel/sysctl.c is a kitchen sink where everyone leaves their dirty
> dishes, this makes it very difficult to maintain.
>
> To help with this maintenance let's start by moving sysctls to places
> where they actually belong. The proc sysctl maintainers do not want to
> know what sysctl knobs you wish to add for your own piece of code, we
> just care about the core logic.
>
> All filesystem syctls now get reviewed by fs folks. This commit
> follows the commit of fs, move the drop_caches sysctls to its own file,
> fs/drop_caches.c.
>
> Signed-off-by: tangmeng <tangmeng@uniontech.com>
Thanks but please send a v3 including all the other patches as well
and collecting the Reviewed/Acked-bys, etc. This can be sent *after*
your v3 of the optimization work.
Luis
next prev parent reply other threads:[~2022-02-26 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 6:10 [PATCH v2 10/11] fs/drop_caches: move drop_caches sysctls to its own file tangmeng
2022-02-26 21:02 ` Luis Chamberlain [this message]
2022-02-27 7:53 ` tangmeng
2022-03-02 2:48 ` tangmeng
2022-04-06 22:25 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhqVW972rnF5L22U@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nixiaoming@huawei.com \
--cc=nizhen@uniontech.com \
--cc=tangmeng@uniontech.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yzaikin@google.com \
--cc=zhanglianjie@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).