From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C620CC433EF for ; Wed, 23 Mar 2022 21:58:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A7206B0072; Wed, 23 Mar 2022 17:58:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2555C6B0073; Wed, 23 Mar 2022 17:58:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11D876B0074; Wed, 23 Mar 2022 17:58:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id 032086B0072 for ; Wed, 23 Mar 2022 17:58:15 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A59E1A5BC5 for ; Wed, 23 Mar 2022 21:58:14 +0000 (UTC) X-FDA: 79277014908.17.C7BD64A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf16.hostedemail.com (Postfix) with ESMTP id EA6A7180031 for ; Wed, 23 Mar 2022 21:58:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=89YbAuXI9BbNTOLNzdMzv6qYGRqw+m92TMqbl+MwwvM=; b=lKqQyKLwsV18YK3hle2Y60Jr2Y Z7lGfQiD0+Och7CcgW1JZVR64mRGIh/cM4hazTGwnUAweDegUIR4j3IVCQw0vNzy0oM3xi7vZgVOg Bd9HZLxmicGWUA09CvHGI9ujA5RumuHLOzTJzs5EGrAg1FTm8R2goxnjmB8wyZsXpc/BSIsf+mN3Y gZKjrQM67Yr9TQb2BcfESbTsZttu2xr4T9IHVEdh/a2C7IUws9LmIAUjiXwPoQ088BKmFIJXM3XFT PuijAQ62VyNZDH5hQimp7xkEPFBS9EobXzOslAcYkaoXVrBcHudaMma8jxYA7b9vsJ5S9tK6tqwV8 rj9RBR2g==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX8zN-00Eutj-SC; Wed, 23 Mar 2022 21:57:57 +0000 Date: Wed, 23 Mar 2022 14:57:57 -0700 From: Luis Chamberlain To: Muchun Song , Masahiro Yamada , linux-kbuild@vger.kernel.org Cc: corbet@lwn.net, mike.kravetz@oracle.com, akpm@linux-foundation.org, keescook@chromium.org, yzaikin@google.com, osalvador@suse.de, david@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, smuchun@gmail.com Subject: Re: [PATCH v5 0/4] add hugetlb_free_vmemmap sysctl Message-ID: References: <20220323125523.79254-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220323125523.79254-1-songmuchun@bytedance.com> X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=lKqQyKLw; spf=none (imf16.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EA6A7180031 X-Stat-Signature: 7yowwgjm95pc1diyqjzhrwxs3b1tfoki X-HE-Tag: 1648072693-443772 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Masahiro, can I trouble you to help review the first patch here? I thought something like this might be possible, and Muchun has done some good work to try it. If anyone can find hole on that kconfig hack it would be you. I'll bounce you a copy of the patches. Luis On Wed, Mar 23, 2022 at 08:55:19PM +0800, Muchun Song wrote: > This series is based on next-20220310. > > This series amis to add hugetlb_free_vmemmap sysctl to enable the feature > of freeing vmemmap pages of HugeTLB pages. > > v5: > - Fix not working properly if one is workig off of a very clean build > reported by Luis Chamberlain. > - Add Suggested-by for Luis Chamberlain. > > Thanks. > > v4: > - Introduce STRUCT_PAGE_SIZE_IS_POWER_OF_2 inspired by Luis. > > v3: > - Add pr_warn_once() (Mike). > - Handle the transition from enabling to disabling (Luis) > > v2: > - Fix compilation when !CONFIG_MHP_MEMMAP_ON_MEMORY reported by kernel > test robot . > - Move sysctl code from kernel/sysctl.c to mm/hugetlb_vmemmap.c. > > Muchun Song (4): > mm: hugetlb_vmemmap: introduce STRUCT_PAGE_SIZE_IS_POWER_OF_2 > mm: memory_hotplug: override memmap_on_memory when > hugetlb_free_vmemmap=on > sysctl: allow to set extra1 to SYSCTL_ONE > mm: hugetlb_vmemmap: add hugetlb_free_vmemmap sysctl > > Documentation/admin-guide/sysctl/vm.rst | 14 +++++ > Kbuild | 14 +++++ > fs/Kconfig | 1 + > include/linux/memory_hotplug.h | 9 +++ > include/linux/mm_types.h | 2 + > kernel/sysctl.c | 2 +- > mm/Kconfig | 3 + > mm/hugetlb_vmemmap.c | 107 ++++++++++++++++++++++++-------- > mm/hugetlb_vmemmap.h | 4 +- > mm/memory_hotplug.c | 27 ++++++-- > mm/struct_page_size.c | 19 ++++++ > scripts/check_struct_page_po2.sh | 9 +++ > 12 files changed, 177 insertions(+), 34 deletions(-) > create mode 100644 mm/struct_page_size.c > create mode 100755 scripts/check_struct_page_po2.sh > > -- > 2.11.0 >