From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40C85C433EF for ; Mon, 28 Mar 2022 08:14:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59B518D0002; Mon, 28 Mar 2022 04:14:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54B368D0001; Mon, 28 Mar 2022 04:14:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43A0C8D0002; Mon, 28 Mar 2022 04:14:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 350208D0001 for ; Mon, 28 Mar 2022 04:14:15 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id E7A24611C4 for ; Mon, 28 Mar 2022 08:14:14 +0000 (UTC) X-FDA: 79293082470.09.1FAB45F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf15.hostedemail.com (Postfix) with ESMTP id 5D850A0031 for ; Mon, 28 Mar 2022 08:14:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E38B9210DF; Mon, 28 Mar 2022 08:14:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1648455252; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+vB3veO+w1AVdDAZ0JQhhQ3DjaQr7v+h/WkhgJ35PGw=; b=vtdyileMsiHdQjXtZsBNq3VQd7NYxSTqvtpD+3ocgDKaovgWVAmpworFzvJcDUSp5uMyf1 QvCD17WtoZnghedU8Qa9q0C0Yn9x9OEqInx1pUEjyjt5tQK1IwcWz6yWME0kTwv3HupCz3 EYcK8xPP5He6PyWfcVPqWoTfU/CkrsY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1648455252; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+vB3veO+w1AVdDAZ0JQhhQ3DjaQr7v+h/WkhgJ35PGw=; b=cGtUK9BBZIGORuB+sT5IQyPvpZof6ulpigSinoQyDFSZmN4zdt+hnSngkQ2Wu7aeITRbOG TNccGsRtCq7H4XBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 587C013215; Mon, 28 Mar 2022 08:14:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id W79jEVRuQWInBgAAMHmgww (envelope-from ); Mon, 28 Mar 2022 08:14:12 +0000 Date: Mon, 28 Mar 2022 10:14:10 +0200 From: Oscar Salvador To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ying.huang@intel.com, mgorman@techsingularity.net Subject: Re: [PATCH 1/2] mm/vmscan: reclaim only affects managed_zones Message-ID: References: <20220327024101.10378-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220327024101.10378-1-richard.weiyang@gmail.com> Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vtdyileM; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=cGtUK9BB; spf=pass (imf15.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Stat-Signature: 6mntidpb4exu1t8byjyp6cimcefsqycs X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5D850A0031 X-HE-Tag: 1648455254-414505 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 27, 2022 at 02:41:00AM +0000, Wei Yang wrote: > As mentioned in commit 6aa303defb74 ("mm, vmscan: only allocate and > reclaim from zones with pages managed by the buddy allocator") , reclaim > only affects managed_zones. > > Let's adjust the code and comment accordingly. > > Signed-off-by: Wei Yang LGTM, Reviewed-by: Oscar Salvador We still have some other places scattered all over where we use populated_zone(). I think it should be great to check whether all those usages are right. -- Oscar Salvador SUSE Labs