From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22053C433F5 for ; Wed, 30 Mar 2022 05:42:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 707258D0003; Wed, 30 Mar 2022 01:42:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68F258D0001; Wed, 30 Mar 2022 01:42:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A7258D0003; Wed, 30 Mar 2022 01:42:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id 3F1288D0001 for ; Wed, 30 Mar 2022 01:42:06 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7FA6C18294A5D for ; Wed, 30 Mar 2022 05:42:05 +0000 (UTC) X-FDA: 79299956610.17.0DDB046 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id 0E3D3180007 for ; Wed, 30 Mar 2022 05:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XYYGWYlGuqIll3206prQVGyP0v/a7w+dmLgKcE4zaws=; b=jHHEU4mvd0H5k2hZQ2Oh1VIDR3 ZsbE/wCHfCB3yo6Tv3WBxleJOBG5ac3ibd3V6uBxVQCqrxXmSfZyD6hLBU7jrd4ZYlnTDcbU4X3EA 4qzEE0C1hDU3VdFrAO0w5xxIA/+PsG8trZyx992Le9Grzq1a36f3m07Dbvj1SXjQqr/UZP70leQTg HrTR85viFYLEBCb4gcSTqrZvQq2/1kGUszwuEO7eefI/g0/2iJ/crGr9oCCfcZiVisT/j39xzcLh0 XcnL1oWNCPc0aLsQEryrtCXzxkh2yA0drzYSof6Xj0pKdU8LsIL60mtA3sY6JyhsWwkaUIoB7ZNHF KTpo10vg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZR5i-00EMe6-R7; Wed, 30 Mar 2022 05:41:58 +0000 Date: Tue, 29 Mar 2022 22:41:58 -0700 From: Christoph Hellwig To: Shiyang Ruan Cc: Dan Williams , Linux Kernel Mailing List , linux-xfs , Linux NVDIMM , Linux MM , linux-fsdevel , "Darrick J. Wong" , david , Christoph Hellwig , Jane Chu Subject: Re: [PATCH v11 1/8] dax: Introduce holder for dax_device Message-ID: References: <20220227120747.711169-1-ruansy.fnst@fujitsu.com> <20220227120747.711169-2-ruansy.fnst@fujitsu.com> <4fd95f0b-106f-6933-7bc6-9f0890012b53@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4fd95f0b-106f-6933-7bc6-9f0890012b53@fujitsu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0E3D3180007 X-Stat-Signature: 6ftinm7dq6bxex5edy8ogxz7u55w9t6e Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=jHHEU4mv; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV+ea9b0106c62401bc49c3+6793+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ea9b0106c62401bc49c3+6793+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-HE-Tag: 1648618924-654047 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 16, 2022 at 09:46:07PM +0800, Shiyang Ruan wrote: > > Forgive me if this has been discussed before, but since dax_operations > > are in terms of pgoff and nr pages and memory_failure() is in terms of > > pfns what was the rationale for making the function signature byte > > based? > > Maybe I didn't describe it clearly... The @offset and @len here are > byte-based. And so is ->memory_failure(). Yes, but is there a good reason for that when the rest of the DAX code tends to work in page chunks?