From: Matthew Wilcox <willy@infradead.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: akpm@linux-foundation.org, ying.huang@intel.com,
songmuchun@bytedance.com, hch@infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/9] mm/vmscan: introduce helper function reclaim_page_list()
Date: Mon, 11 Apr 2022 04:17:40 +0100 [thread overview]
Message-ID: <YlOd1Lvw6ia1vul2@casper.infradead.org> (raw)
In-Reply-To: <18ac3908-d162-f1ea-e91f-1da203272b74@huawei.com>
On Mon, Apr 11, 2022 at 09:53:15AM +0800, Miaohe Lin wrote:
> On 2022/4/9 21:44, Matthew Wilcox wrote:
> > On Sat, Apr 09, 2022 at 05:34:54PM +0800, Miaohe Lin wrote:
> >> + nr_reclaimed = shrink_page_list(page_list, pgdat, &sc, &dummy_stat, false);
> >> + while (!list_empty(page_list)) {
> >> + folio = lru_to_folio(page_list);
> >> + list_del(&folio->lru);
> >> + putback_lru_page(&folio->page);
> >
> > folio_putback_lru()
>
> I thought folio_putback_lru is deliberately not to use because there is no caller of folio_putback_lru now.
> But it seems I was wrong. Will do it in next version.
Looks like all of the uses of it that I mooted during the last merge
window ended up going away.
https://lore.kernel.org/all/20220204195852.1751729-47-willy@infradead.org/
was obsoleted by commit b109b87050df
https://lore.kernel.org/all/20220204195852.1751729-48-willy@infradead.org/
and
https://lore.kernel.org/all/20220204195852.1751729-50-willy@infradead.org/
were also obsoleted by Hugh's mlock changes
I also sent
https://lore.kernel.org/all/YjJJIrENYb1qFHzl@casper.infradead.org/
but never quite got it up to submittable quality.
next prev parent reply other threads:[~2022-04-11 3:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 9:34 [PATCH v2 0/9] A few cleanup and fixup patches for vmscan Miaohe Lin
2022-04-09 9:34 ` [PATCH v2 1/9] mm/vmscan: add a comment about MADV_FREE pages check in folio_check_dirty_writeback Miaohe Lin
2022-04-11 11:50 ` ying.huang
2022-04-12 3:07 ` Miaohe Lin
2022-04-11 14:16 ` Christoph Hellwig
2022-04-12 3:15 ` Miaohe Lin
2022-04-12 8:44 ` Oscar Salvador
2022-04-09 9:34 ` [PATCH v2 2/9] mm/vmscan: remove unneeded can_split_huge_page check Miaohe Lin
2022-04-11 14:18 ` Christoph Hellwig
2022-04-12 3:14 ` Miaohe Lin
2022-04-12 0:52 ` ying.huang
2022-04-12 8:59 ` Oscar Salvador
2022-04-12 13:42 ` Miaohe Lin
2022-04-12 14:59 ` David Hildenbrand
2022-04-13 1:26 ` ying.huang
2022-04-13 2:17 ` Miaohe Lin
2022-04-15 3:07 ` ying.huang
2022-04-16 2:34 ` Miaohe Lin
2022-04-09 9:34 ` [PATCH v2 3/9] mm/vmscan: introduce helper function reclaim_page_list() Miaohe Lin
2022-04-09 13:44 ` Matthew Wilcox
2022-04-11 1:53 ` Miaohe Lin
2022-04-11 3:17 ` Matthew Wilcox [this message]
2022-04-11 3:26 ` Miaohe Lin
2022-04-09 9:34 ` [PATCH v2 4/9] mm/vmscan: save a bit of stack space in shrink_lruvec Miaohe Lin
2022-04-12 0:57 ` ying.huang
2022-04-12 3:13 ` Miaohe Lin
2022-04-09 9:34 ` [PATCH v2 5/9] mm/vmscan: activate swap-backed executable folios after first usage Miaohe Lin
2022-04-12 0:59 ` ying.huang
2022-04-09 9:34 ` [PATCH v2 6/9] mm/vmscan: take all base pages of THP into account when race with speculative reference Miaohe Lin
2022-04-09 9:34 ` [PATCH v2 7/9] mm/vmscan: take min_slab_pages into account when try to call shrink_node Miaohe Lin
2022-04-12 1:36 ` ying.huang
2022-04-09 9:34 ` [PATCH v2 8/9] mm/vmscan: remove obsolete comment in kswapd_run Miaohe Lin
2022-04-09 9:35 ` [PATCH v2 9/9] mm/vmscan: use helper folio_is_file_lru() Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlOd1Lvw6ia1vul2@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=songmuchun@bytedance.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).