From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E2D8C433F5 for ; Mon, 11 Apr 2022 06:37:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C030E6B0072; Mon, 11 Apr 2022 02:37:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB2916B0073; Mon, 11 Apr 2022 02:37:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA4216B0074; Mon, 11 Apr 2022 02:37:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 9C9206B0072 for ; Mon, 11 Apr 2022 02:37:23 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7CEC123CC4 for ; Mon, 11 Apr 2022 06:37:23 +0000 (UTC) X-FDA: 79343641566.06.9E7835C Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP id 0F477C0008 for ; Mon, 11 Apr 2022 06:37:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zuE9Oa+Qeir18sQSYzqnRYIpuPNJeRgzj07o7ivdwmk=; b=jhLaW6gCJNXjHQjbpXI001NoLm AdFauJ9hVbDbbdwuShc0kE3TWVJ7U6cHbS1IVv5Dkz7vDn/LxPDJbM1rz1CQYtaBq9enHaO+9NlL/ jw3q0mng0Gv7hWxJJvqwU/5geav0RGI5PD2R26zZwNTmbVZ0e2qgaOoci6Tk8P03ECRbTlHhAWhWI Nu2CciiC2elMY1Hh1rOZEbKyZ+CMYK7ToiTB8yDWTIR+NTU9faXcILk2jK5BIglpKBW1v2DZQYhXT c4S6MZxbtPM/AI23zj/vdJiRazAwFyTd0o2QCLP287g1iNfUVd0oCI7ghVyoF7Tju6mc5yarGTDAJ +XuGp9AA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndnfr-006wdX-RD; Mon, 11 Apr 2022 06:37:19 +0000 Date: Sun, 10 Apr 2022 23:37:19 -0700 From: Christoph Hellwig To: Shiyang Ruan Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org, jane.chu@oracle.com, Christoph Hellwig Subject: Re: [PATCH v12 2/7] mm: factor helpers for memory_failure_dev_pagemap Message-ID: References: <20220410160904.3758789-1-ruansy.fnst@fujitsu.com> <20220410160904.3758789-3-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220410160904.3758789-3-ruansy.fnst@fujitsu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: zp8einjp1ej7en9wxrub5tyf5dct491j Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=jhLaW6gC; dmarc=none; spf=none (imf10.hostedemail.com: domain of BATV+28f505242231dd703457+6805+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+28f505242231dd703457+6805+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 0F477C0008 X-HE-Tag: 1649659042-967032 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + unmap_and_kill(&to_kill, pfn, page->mapping, page->index, flags); > +unlock: > + dax_unlock_page(page, cookie); > + return 0; As the buildbot points out this should probably be a "return rc".