From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0DF8C433FE for ; Mon, 11 Apr 2022 06:40:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 659F86B0072; Mon, 11 Apr 2022 02:40:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 609C46B0073; Mon, 11 Apr 2022 02:40:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 520486B0074; Mon, 11 Apr 2022 02:40:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 487C86B0072 for ; Mon, 11 Apr 2022 02:40:02 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 17359615F8 for ; Mon, 11 Apr 2022 06:40:02 +0000 (UTC) X-FDA: 79343648244.12.B47C86C Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id AC44AC0002 for ; Mon, 11 Apr 2022 06:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M09IzlW+N1WwFLRoKBoXQhmkTfiayS6+tKZLiDRa9cM=; b=vuYRGKESL2/4qm8Aezet9aPx4W +nyvgXHqbKV8O/sdkchzpTN0JP8s+Z+FPEBDRwarRsRbFqp2ZnRDOyu+W9z93H5iHy2pdUCD9XgL3 j7TJH2gQyaMfCoijPZqyy5a9A4X+cKOMX2LVS1qbnbXimkEvdbeLgdSU0uGUXBoSp0UoshnrLBNEm A/V/RaLAeZrpWRq7OuusbYUJ2NFL4+Fm393i7D+mawqNJ0cZ0W9Uz48YBYQIZej1ogcwGrA+cmV8c eyCdR0EJm5AqpL54XYS32PcZLYDLrDaTkXXtTvDQIk+fBd3Enmi4giwIWOQcO0B1zHVJALhjFWIxv y1SlBf+g==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndniQ-006xNn-5v; Mon, 11 Apr 2022 06:39:58 +0000 Date: Sun, 10 Apr 2022 23:39:58 -0700 From: Christoph Hellwig To: Shiyang Ruan Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org, jane.chu@oracle.com Subject: Re: [PATCH v12 6/7] xfs: Implement ->notify_failure() for XFS Message-ID: References: <20220410160904.3758789-1-ruansy.fnst@fujitsu.com> <20220410160904.3758789-7-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220410160904.3758789-7-ruansy.fnst@fujitsu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=vuYRGKES; spf=none (imf22.hostedemail.com: domain of BATV+28f505242231dd703457+6805+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+28f505242231dd703457+6805+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: AC44AC0002 X-Stat-Signature: 5y1snhh78zp4f4apx5si17r5n7wxta7j X-HE-Tag: 1649659201-931610 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > --- a/fs/xfs/xfs_super.h > +++ b/fs/xfs/xfs_super.h > @@ -93,6 +93,7 @@ extern xfs_agnumber_t xfs_set_inode_alloc(struct xfs_mount *, > extern const struct export_operations xfs_export_operations; > extern const struct xattr_handler *xfs_xattr_handlers[]; > extern const struct quotactl_ops xfs_quotactl_operations; > +extern const struct dax_holder_operations xfs_dax_holder_operations; This needs to be defined to NULL if at least one of CONFIG_FS_DAX or CONFIG_MEMORY_FAILURE is not set. Otherwise looks good: Reviewed-by: Christoph Hellwig