From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45A25C433EF for ; Thu, 14 Apr 2022 21:11:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB4B16B0071; Thu, 14 Apr 2022 17:11:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A62D96B0073; Thu, 14 Apr 2022 17:11:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92AB16B0074; Thu, 14 Apr 2022 17:11:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 8324F6B0071 for ; Thu, 14 Apr 2022 17:11:43 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4F2C53270 for ; Thu, 14 Apr 2022 21:11:43 +0000 (UTC) X-FDA: 79356731286.07.8F1C477 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf24.hostedemail.com (Postfix) with ESMTP id DCE45180002 for ; Thu, 14 Apr 2022 21:11:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=t0kR90lwAnP+kfHrPPmywzlT1a0RSvToeleriKjsR2s=; b=2UbJ48VYL4vK73QTj2OMgNcry0 68NtsJ94tbzdSmiegtINzjW/PatF+HTZZTsOxUm6Inrt2jCYsiGG1eyIgMccz4Z3rpROWRqs4Lc2D 5e8Fwo+N6z/f1Ts4aNtsnUHq5P9h2O1a7lQfnen0bnKP7CcdX2AS5UvW1UmpgRqhyPIE3uJed2rky 8U2nhVdXVBkhMqzn+12WL1P0NTC43y/BVYmsggjMEDcdNv8peim+2fGaQgkYJ+DIy2jWbOeTAbQyJ MceLsfqKzoQD3tfWzm7JMzcRkpdF6Seu7npTg/ieIIbEKwiu/uopcb6yfSjQCq6HmHMOkKHIjmwCh VKiO7L4g==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nf6kd-007Jom-NH; Thu, 14 Apr 2022 21:11:39 +0000 Date: Thu, 14 Apr 2022 14:11:39 -0700 From: Luis Chamberlain To: Song Liu , Linus Torvalds Cc: bpf , Linux-MM , open list , Alexei Starovoitov , Daniel Borkmann , Kernel Team , Andrew Morton , "Edgecombe, Rick P" , Christoph Hellwig , imbrenda@linux.ibm.com Subject: Re: [PATCH v3 bpf RESEND 3/4] module: introduce module_alloc_huge Message-ID: References: <20220414195914.1648345-1-song@kernel.org> <20220414195914.1648345-4-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DCE45180002 X-Stat-Signature: dkdmgiyqfu7iu4g49en8d8eurdr5snmf Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=2UbJ48VY; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf24.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org X-HE-Tag: 1649970702-835027 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 14, 2022 at 02:03:17PM -0700, Song Liu wrote: > Hi Luis, > > On Thu, Apr 14, 2022 at 1:34 PM Luis Chamberlain wrote: > > > > On Thu, Apr 14, 2022 at 12:59:13PM -0700, Song Liu wrote: > > > Introduce module_alloc_huge, which allocates huge page backed memory in > > > module memory space. The primary user of this memory is bpf_prog_pack > > > (multiple BPF programs sharing a huge page). > > > > > > Signed-off-by: Song Liu > > > > See modules-next [0], as modules.c has been chopped up as of late. > > So if you want this to go throug modules this will need to rebased > > on that tree. fortunately the amount of code in question does not > > seem like much. > > > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=modules-next > > We are hoping to ship this with to 5.18, as the set addresses some issue with > huge page backed vmalloc. I guess we cannot ship it via modules-next branch. > Huh, you intend this to go in as a fix for v5.18 (already released) once properly reviewed? This seems quite large... for a fix. > How about we ship module_alloc_huge() to 5.18 in module.c for now, and once > we update modules-next branch, I will send another patch to clean it up? I rather set the expectations right about getting such a large fix in for v5.18. I haven't even sat down to review all the changes in light of this, but a cursorary glance seems to me it's rather "large" for a fix. Luis