From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1A69C433EF for ; Fri, 15 Apr 2022 06:32:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 361496B0074; Fri, 15 Apr 2022 02:32:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 311256B0075; Fri, 15 Apr 2022 02:32:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D85C6B0078; Fri, 15 Apr 2022 02:32:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 1087C6B0074 for ; Fri, 15 Apr 2022 02:32:06 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E4E0162A21 for ; Fri, 15 Apr 2022 06:32:05 +0000 (UTC) X-FDA: 79358143410.08.CA23A3B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id 6B2FCA0006 for ; Fri, 15 Apr 2022 06:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AlSJrh/9aVdD6cccT4WMJlmUmFpg/2qtlWCw6b8UaS8=; b=C85NOtrZeDmbcQIJtBMn+UH4yg wAE14ydK2cPQcvA6sTvku0725EUU2bbJWA2cYyN2u9LD4UJOa+yettotZc5rO0g7KnNlAyEFW16K7 hg62RpMXTl5L/Yz0ZYkSxPWqx4oLJIlSXpL8KvoAtrWQbcNeOrvmbCbY8xelRO/gbyF/UpQ01jPQF vJyVmnMhijlVS9O0NhmANtGNZ10CI+W+5CaLCIQOAn8ZlhswxHSjFe9g7rb8uVHo2NaJLGMqQBTe6 ptdU5ynL/jRR9whMLC6m2YXic1KtNhebfGx23pgAY/mQ2xg/CVO6JVuLS5twqV8+8KH8I53Xfnnkr B8r2XJbw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfFUx-0090pQ-Gn; Fri, 15 Apr 2022 06:32:03 +0000 Date: Thu, 14 Apr 2022 23:32:03 -0700 From: Christoph Hellwig To: Song Liu Cc: bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, kernel-team@fb.com, akpm@linux-foundation.org, rick.p.edgecombe@intel.com, hch@infradead.org, imbrenda@linux.ibm.com, mcgrof@kernel.org Subject: Re: [PATCH v3 bpf RESEND 2/4] page_alloc: use __vmalloc_huge for large system hash Message-ID: References: <20220414195914.1648345-1-song@kernel.org> <20220414195914.1648345-3-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220414195914.1648345-3-song@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=C85NOtrZ; dmarc=none; spf=none (imf15.hostedemail.com: domain of BATV+2d633663de0085320ac7+6809+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d633663de0085320ac7+6809+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6B2FCA0006 X-Stat-Signature: r945ojkpsoyjoue9zwy4twxukkyr6sku X-HE-Tag: 1650004325-694117 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 14, 2022 at 12:59:12PM -0700, Song Liu wrote: > Use __vmalloc_huge() in alloc_large_system_hash() so that large system > hash (>= PMD_SIZE) could benefit from huge pages. Note that __vmalloc_huge > only allocates huge pages for systems with HAVE_ARCH_HUGE_VMALLOC. Looks good (modulo the possible naming chane suggested in patch 1): Reviewed-by: Christoph Hellwig