From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18553C433EF for ; Sun, 17 Apr 2022 08:51:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E9AE6B0072; Sun, 17 Apr 2022 04:51:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 999A46B0073; Sun, 17 Apr 2022 04:51:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8613C6B0074; Sun, 17 Apr 2022 04:51:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 72DFD6B0072 for ; Sun, 17 Apr 2022 04:51:00 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 31A6E23AB1 for ; Sun, 17 Apr 2022 08:51:00 +0000 (UTC) X-FDA: 79365751080.25.9D71352 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf10.hostedemail.com (Postfix) with ESMTP id B1674C0003 for ; Sun, 17 Apr 2022 08:50:59 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9F553B80B29; Sun, 17 Apr 2022 08:50:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50D38C385A4; Sun, 17 Apr 2022 08:50:54 +0000 (UTC) Date: Sun, 17 Apr 2022 09:50:50 +0100 From: Catalin Marinas To: Herbert Xu Cc: Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" Subject: Re: [PATCH 07/10] crypto: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf10.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B1674C0003 X-Stat-Signature: no3e5g7qcj9feznu13cp3dqwp69kxnr4 X-HE-Tag: 1650185459-59537 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 17, 2022 at 04:35:58PM +0800, Herbert Xu wrote: > On Sun, Apr 17, 2022 at 09:31:09AM +0100, Catalin Marinas wrote: > > > > Not with my series, the non-sharing of cache lines is preserved. > > kmalloc() still returns objects aligned to a cache-line. > > ARCH_DMA_MINALIGN was chosen as the cover-all value for all SoCs > > supported but I want to reduce the kmalloc() alignment to a cache line > > size if a platform has a cache line smaller than ARCH_DMA_MINALIGN (most > > arm64 SoCs have a cache line of 64 bytes rather than 128). > > OK, but then you don't need to play with CRYPTO_MINALIGN at all, > right? All you need to do is add the padding between the Crypto > API fields and the context structure, right? Right, if that's what you prefer. Something like: diff --git a/include/linux/crypto.h b/include/linux/crypto.h index 2324ab6f1846..bb645b2f2718 100644 --- a/include/linux/crypto.h +++ b/include/linux/crypto.h @@ -645,7 +645,7 @@ struct crypto_tfm { struct crypto_alg *__crt_alg; - void *__crt_ctx[] CRYPTO_MINALIGN_ATTR; + void *__crt_ctx[] __aligned(ARCH_DMA_MINALIGN); }; But once we do that, are there any other CRYPTO_MINALIGN left around? -- Catalin