From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C646C433F5 for ; Mon, 2 May 2022 07:24:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25EBA6B0072; Mon, 2 May 2022 03:24:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20DE56B0073; Mon, 2 May 2022 03:24:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08B706B0074; Mon, 2 May 2022 03:24:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id EB5D96B0072 for ; Mon, 2 May 2022 03:24:33 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B8D782AB63 for ; Mon, 2 May 2022 07:24:33 +0000 (UTC) X-FDA: 79419965226.07.F763AAB Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by imf06.hostedemail.com (Postfix) with ESMTP id A519C180079 for ; Mon, 2 May 2022 07:24:31 +0000 (UTC) Received: by mail-io1-f49.google.com with SMTP id f2so14997572ioh.7 for ; Mon, 02 May 2022 00:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=U3yK116U7QtcL5LqxzCgKsq8iaHrCKZT63ym/sXbAKc=; b=Bzi+R0R7QaC+1bjX2bo/eUhZOcarNK1lhHQK3BnkDNsZ/YQ2kF65HgubGNE1g9QjAF VClt8yFpYSC5oht9s5BVdGzylLx1SGefdWn/yZSkP43v9ZQ/U115ldRP4mIaned4xy+i XIOYoMJFeLcWOEhr5AxcXnBEpdEmwdLfO6uO7xJ6U4GX4NaQbgjWU8WH2H/DzUzqOLnG Y07pCf3IIYshAUYH77brXREcB5+CeW72v1d84nST1hyzetu4eMbN4GXW/ybvmO2gKA4z 6cXwi4THka5cWO2I5lnhUndPk6YD5GJn9zIhAtE8MWZojqFyir63YUwehSgoAGHPtqPb sMAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=U3yK116U7QtcL5LqxzCgKsq8iaHrCKZT63ym/sXbAKc=; b=3jjVxVRSy7AapMx4KVYxtpD6AyFvwrZ907ooSSUSsHRrQ3hIidXt6BiRaInYna6enG f0WJ/pJUZ6bJbd5P6tycShKe56GU1KMxbrabyM4L/MgQ5hciVdapFtLWfw3nfQJuNkDt YLjm9gXG7X3G6rvJIvVsHZDurpjY2HRzcleqRJFdh9SoVLzs24PVgzSJCyYcMhFxCvn7 cZy5Y5izUFmAn4n5vHBRbVVWmfinusScKd4buQOT8r5AiO6i2kYhTbN407hsLhwrIrj2 RFx2CpFrxm6MZalec+9KABUhoMHBLeU1uN42eU1Y8rdOJkP5P7NM8YnCkHlTmp81u9YT 5GRQ== X-Gm-Message-State: AOAM531DRrhAmUigDJRbdYzi5UJkZk+LJAyXF+hwNRk9lyD/CuPPi6rD nCdmLQ07/gSQj4O9HEAuJaJymw== X-Google-Smtp-Source: ABdhPJxeI2hWA90VpSmXaKqPppDo5J6dwWDCrTz4glAq2DiVVqCq9f3COwPcysvhW/KDXqg9MvY5ZQ== X-Received: by 2002:a05:6638:2643:b0:323:c3e3:fcec with SMTP id n3-20020a056638264300b00323c3e3fcecmr4517508jat.289.1651476272267; Mon, 02 May 2022 00:24:32 -0700 (PDT) Received: from google.com (194.225.68.34.bc.googleusercontent.com. [34.68.225.194]) by smtp.gmail.com with ESMTPSA id z7-20020a926507000000b002cde6e352e5sm2494262ilb.47.2022.05.02.00.24.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 00:24:31 -0700 (PDT) Date: Mon, 2 May 2022 07:24:28 +0000 From: Oliver Upton To: Yosry Ahmed Cc: Tejun Heo , Johannes Weiner , Zefan Li , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 4/4] KVM: arm64/mmu: count KVM s2 mmu usage in secondary pagetable stats Message-ID: References: <20220429201131.3397875-1-yosryahmed@google.com> <20220429201131.3397875-5-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220429201131.3397875-5-yosryahmed@google.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A519C180079 X-Stat-Signature: 47g9x3sg9he6gsb5eggrg3h4mmao4xf7 X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Bzi+R0R7; spf=pass (imf06.hostedemail.com: domain of oupton@google.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=oupton@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1651476271-106728 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yosry, On Fri, Apr 29, 2022 at 08:11:31PM +0000, Yosry Ahmed wrote: > Count the pages used by KVM in arm64 for stage2 mmu in secondary pagetable > stats. > > Signed-off-by: Yosry Ahmed > --- > arch/arm64/kvm/mmu.c | 35 +++++++++++++++++++++++++++++++---- > 1 file changed, 31 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index 53ae2c0640bc..fc5030307cce 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -92,9 +92,13 @@ static bool kvm_is_device_pfn(unsigned long pfn) > static void *stage2_memcache_zalloc_page(void *arg) > { > struct kvm_mmu_memory_cache *mc = arg; > + void *virt; > > /* Allocated with __GFP_ZERO, so no need to zero */ > - return kvm_mmu_memory_cache_alloc(mc); > + virt = kvm_mmu_memory_cache_alloc(mc); > + if (virt) > + kvm_account_pgtable_pages(virt, +1); Sorry I didn't say it last time around, would now be a good time to clean up the funky sign convention of kvm_mod_used_mmu_pages()? Or limit the funk to just x86 :) -- Thanks, Oliver