From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A6E7C433FE for ; Tue, 26 Apr 2022 19:07:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C97566B0073; Tue, 26 Apr 2022 15:07:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C37A76B0074; Tue, 26 Apr 2022 15:07:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B00536B0075; Tue, 26 Apr 2022 15:07:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id A35EB6B0073 for ; Tue, 26 Apr 2022 15:07:03 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 926F7603C3 for ; Tue, 26 Apr 2022 19:07:03 +0000 (UTC) X-FDA: 79399962726.01.AAEEABC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id D89A518005D for ; Tue, 26 Apr 2022 19:06:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=B1SlxgZnhDUv62Meok/Uu1ZlEfn1sYvml/husNq9EFk=; b=Rg9I6iE7iBm2gZ0pnunKbQuLph 3W2laBbrkE61WD0EcujIQ+3x+7XcZN4aoaGo1ULY5exrjuA48m375e6lP4e0i87fAE/mg2hPlNM2t zlMGyshYnDTWiKUQwOvtUOKmIXt1RrdiqbbLwv04wcWZOIBQVWksH4zIvBG2a9JtlzUlgwoiMS1oh 4KHtc6IMkwAH7sdlElErNI0FFYOhvvlRNa2jSTafq+fFXnMaQH+vy6D0tsjmgL2yMMKOpSegxVqAQ 7hbv+h2LKx4UZQy9zU9yg0C4Rjl4bK3l0WU57AhabP0aCt54SHvIPKWC6fDARGRHid0HzClMr218b 594TbfeA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1njQWQ-009vVJ-E3; Tue, 26 Apr 2022 19:06:50 +0000 Date: Tue, 26 Apr 2022 20:06:50 +0100 From: Matthew Wilcox To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com Subject: Re: [RFC PATCH v1 02/18] mm: add FGP_ATOMIC flag to __filemap_get_folio() Message-ID: References: <20220426174335.4004987-1-shr@fb.com> <20220426174335.4004987-3-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220426174335.4004987-3-shr@fb.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D89A518005D Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Rg9I6iE7; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspam-User: X-Stat-Signature: dxgoayzjzfr98bgg3o5kqiywj8ewrg9x X-HE-Tag: 1651000018-475109 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 26, 2022 at 10:43:19AM -0700, Stefan Roesch wrote: > Define FGP_ATOMIC flag and add support for the new flag in the function > __filemap_get_folio(). No. You don't get to use the emergency memory pools for doing writes. That completely screws up the MM.