From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jagdish Gediya <jvgediya@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Jonathan.Cameron@huawei.com, adobriyan@gmail.com,
akpm@linux-foundation.org, rf@opensource.cirrus.com,
pmladek@suse.com, ying.huang@intel.com, dave.hansen@intel.com
Subject: Re: [PATCH v2 2/2] mm: Covert sysfs input to bool using kstrtobool()
Date: Wed, 27 Apr 2022 18:17:29 +0300 [thread overview]
Message-ID: <YmleidxlL2/d859f@smile.fi.intel.com> (raw)
In-Reply-To: <20220426170040.65487-2-jvgediya@linux.ibm.com>
On Tue, Apr 26, 2022 at 10:30:40PM +0530, Jagdish Gediya wrote:
> Sysfs input conversion to corrosponding bool value e.g. "false" or "0"
> to false, "true" or "1" to true are currently handled through strncmp
> at multiple places. Use kstrtobool() to convert sysfs input to bool
> value.
...
> + if (kstrtobool(buf, &numa_demotion_enabled))
> return -EINVAL;
Hmm... The commit message doesn't explain what's wrong with the error codes
returned by kstrtobool(). Can't it be
ret = kstrtobool();
if (ret)
return ret;
?
...
> + if (kstrtobool(buf, &enable_vma_readahead))
> return -EINVAL;
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-04-27 15:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 17:00 [PATCH v2 1/2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool() Jagdish Gediya
2022-04-26 17:00 ` [PATCH v2 2/2] mm: Covert sysfs input to bool using kstrtobool() Jagdish Gediya
2022-04-26 17:24 ` Matthew Wilcox
2022-04-27 15:17 ` Andy Shevchenko [this message]
2022-05-13 1:05 ` Andrew Morton
2022-05-13 18:28 ` Alexey Dobriyan
2022-05-16 10:48 ` Jagdish Gediya
2022-05-16 10:47 ` Jagdish Gediya
2022-04-26 17:23 ` [PATCH v2 1/2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool() Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmleidxlL2/d859f@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=jvgediya@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pmladek@suse.com \
--cc=rf@opensource.cirrus.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).