From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D3E7C433EF for ; Wed, 27 Apr 2022 20:29:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED8786B0071; Wed, 27 Apr 2022 16:29:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E87036B0073; Wed, 27 Apr 2022 16:29:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D27866B0074; Wed, 27 Apr 2022 16:29:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id C18FD6B0071 for ; Wed, 27 Apr 2022 16:29:38 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 88F791215EE for ; Wed, 27 Apr 2022 20:29:38 +0000 (UTC) X-FDA: 79403799636.20.BDEA1EA Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf27.hostedemail.com (Postfix) with ESMTP id C161C40047 for ; Wed, 27 Apr 2022 20:29:36 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id bd19-20020a17090b0b9300b001d98af6dcd1so5880238pjb.4 for ; Wed, 27 Apr 2022 13:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KjZdJc+2UDuaCV9hUSLVuNI4CiOYxCjI+J/98h/W9G4=; b=Tac3djEA5bXqIgvvbxyz8RUsVLAM/lkHxNcYv/gitY3QhUpuLEKTucRMeN/6RsXCGY o+ND4wPwR7gIoVajI8XzV34aqcMZYBllRJa5CVXDwBN9THDIzgLL7016DHdilf1gzjMz JBJSBtSylrg2tT/vIHuAsyDgpuPlKRq43zYsflK5fOqXp1BiJE+1A1+Mu1h/oSLoWtio 2hWay8lfn1y8G5t3h/vJ5ZSoxP6MHkL/FCYcr4gUwQao3/hJOqIu6jF52DW8/vVqxW3u bDaHlEKJ801uxbQhxfssVyszMyKhnTbbk9wfJf/4+AJLMyhhD4fHNXagJ1XlR7rrf97D RTNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=KjZdJc+2UDuaCV9hUSLVuNI4CiOYxCjI+J/98h/W9G4=; b=KENZUyX+znXmkxGD8WKw22VtgIRJ3xGAx8BzBVl87kiO0H2Ai8fKfUCKDwVpn/VwJ6 I0/PdHguUNbZ+SKo7Ud0+Jnfui36vnZgfOfx3AHN8tao54R5onBUGjrTYn1XuRzJ7WsO CwhBF0ytwwkxqtdUs57tje3TOcEy7drWbcJWWvg+utZESyLgAaMdtMdGTw2mHfKef1tA f+3jHmqQZsIe41UDIa5r/8CuXXLvPV2iZNReg+UhVf7d6kLC+7YM1dx6pVOsCa6N9f9P OKK7XxpXo+Bct2Bq2CRJVXPyRhvUeZMxtACf92M6roxMCKx3X3qWa5ZrmH6u63jrGrZ0 ylMA== X-Gm-Message-State: AOAM532zb8KYGEpl31wyDQU5Bs+BL9JBW6ynjiZB5UfptiUQ2Vsmm3+H DGFcoyc9HSjajf3gGL9Ur4Q= X-Google-Smtp-Source: ABdhPJznOXxFH5HHWoubJvtIMRhCBLHqEyqk7PM/z3PtAH8Xc0e4aUUlIjaIlnJushp4AkaYzDUCIA== X-Received: by 2002:a17:903:2285:b0:15b:cd9e:f018 with SMTP id b5-20020a170903228500b0015bcd9ef018mr29018515plh.106.1651091376925; Wed, 27 Apr 2022 13:29:36 -0700 (PDT) Received: from google.com ([2620:15c:211:201:546a:2875:2a75:1b94]) by smtp.gmail.com with ESMTPSA id p27-20020a056a000a1b00b004f3f63e3cf2sm22917044pfh.58.2022.04.27.13.29.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 13:29:36 -0700 (PDT) Date: Wed, 27 Apr 2022 13:29:34 -0700 From: Minchan Kim To: Johannes Weiner Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Seth Jennings , Dan Streetman , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 4/5] mm: zswap: add basic meminfo and vmstat coverage Message-ID: References: <20220427160016.144237-1-hannes@cmpxchg.org> <20220427160016.144237-5-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427160016.144237-5-hannes@cmpxchg.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C161C40047 X-Stat-Signature: m459wze7p5jgq4mce6q33kitgfzoe1xg X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Tac3djEA; spf=pass (imf27.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-HE-Tag: 1651091376-531661 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Johannes, On Wed, Apr 27, 2022 at 12:00:15PM -0400, Johannes Weiner wrote: > Currently it requires poking at debugfs to figure out the size and > population of the zswap cache on a host. There are no counters for > reads and writes against the cache. As a result, it's difficult to > understand zswap behavior on production systems. > > Print zswap memory consumption and how many pages are zswapped out in > /proc/meminfo. Count zswapouts and zswapins in /proc/vmstat. > > Signed-off-by: Johannes Weiner > --- > fs/proc/meminfo.c | 7 +++++++ > include/linux/swap.h | 5 +++++ > include/linux/vm_event_item.h | 4 ++++ > mm/vmstat.c | 4 ++++ > mm/zswap.c | 13 ++++++------- > 5 files changed, 26 insertions(+), 7 deletions(-) > > diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c > index 6fa761c9cc78..6e89f0e2fd20 100644 > --- a/fs/proc/meminfo.c > +++ b/fs/proc/meminfo.c > @@ -86,6 +86,13 @@ static int meminfo_proc_show(struct seq_file *m, void *v) > > show_val_kb(m, "SwapTotal: ", i.totalswap); > show_val_kb(m, "SwapFree: ", i.freeswap); > +#ifdef CONFIG_ZSWAP > + seq_printf(m, "Zswap: %8lu kB\n", > + (unsigned long)(zswap_pool_total_size >> 10)); > + seq_printf(m, "Zswapped: %8lu kB\n", > + (unsigned long)atomic_read(&zswap_stored_pages) << > + (PAGE_SHIFT - 10)); > +#endif I agree it would be very handy to have the memory consumption in meminfo https://lore.kernel.org/all/YYwZXrL3Fu8%2FvLZw@google.com/ If we really go this Zswap only metric instead of general term "Compressed", I'd like to post maybe "Zram:" with same reason in this patchset. Do you think that's better idea instead of introducing general term like "Compressed:" or something else?