From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C61E9C433F5 for ; Wed, 27 Apr 2022 22:16:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 364DE6B0078; Wed, 27 Apr 2022 18:16:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 311A16B007B; Wed, 27 Apr 2022 18:16:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B2E76B007D; Wed, 27 Apr 2022 18:16:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 0B54B6B0078 for ; Wed, 27 Apr 2022 18:16:52 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id D374981823 for ; Wed, 27 Apr 2022 22:16:51 +0000 (UTC) X-FDA: 79404069822.01.86DEA3B Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf04.hostedemail.com (Postfix) with ESMTP id 0E40140064 for ; Wed, 27 Apr 2022 22:16:46 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id k29so2450677pgm.12 for ; Wed, 27 Apr 2022 15:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2RoFaE1ytRBTyXgweqhP00vnNCFBWuqPT9MahXuxpik=; b=TXgc7SpRW4PY86E79NxGxT/h7KY/SJkkCDx3kBxe7VJ98gCHJ86n8sPgZeFo9p/O6c ulCHi53fjQKhKCqe6S8lFxfrbHxZSPxC9kPYHdh9+c7XDZzS90uxFvp3agkHKJe+0Or4 TjPdNh5MxypqyG2xi3F8z3EmdTA8UGKCgbLbVVRingY9D+XGHRAAKkVkIzyMOv1Xm7zG o6Lh4eMvgjkeCHqaZVNCdpuAg0SQ+/QSpPpaAhH2UOBGT49H1VSN3WZwbOTPsqSlhU8T DtrssrAqFHr5TMYpTrQpCvE345AEgT292jIPY3U2lbtqPLbIX4Ftn6BAxNnUcj2onBFZ pnFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=2RoFaE1ytRBTyXgweqhP00vnNCFBWuqPT9MahXuxpik=; b=kKZSh2eFFSovBeXGvuxIIY3mt9ZZShseZYzmwQIj0VetP+5QiufEG7nS3lW0H7zLlJ K7Se252k1crqLoWw2rv+d81VAn3lMOXWXVg/VcmiQLzBWs3Qxo7mqAae49ByngIfogEN 6Z3I52q9im2hxOwM2J2VBc32dr9j8YjQCZOiK4PGfCmh2IPtYC8PA1Z2LW/C/GPAdZAZ MVJ2jgcoVrzpEv9kIy8bPwOsmZTcf3Be/Ok8IdiLABl/2WGvTaAQq6GkgqdyuySTrwn2 n9hw+pnhd5YT00QnZWPbVwPGo1Sxo+cljvh5vR92UuNnPD28EUx/EK06plBUTcNfEtQi SMXg== X-Gm-Message-State: AOAM530/fDK4vB7OvY0JSNwlBBe0X0aToohWF5R6RYaWmoNp3iFTzp0J aZajMIkEtuCmpst0m2L7x00= X-Google-Smtp-Source: ABdhPJxG8fhTyLclRTDp7SI0nqPDWxAD3Pb244ovq9B02YRPOPT0/gNbh0cMUp+VSmNA5FRn3wH87Q== X-Received: by 2002:a05:6a00:22c7:b0:50d:605d:2d28 with SMTP id f7-20020a056a0022c700b0050d605d2d28mr9896981pfj.80.1651097810561; Wed, 27 Apr 2022 15:16:50 -0700 (PDT) Received: from google.com ([2620:15c:211:201:546a:2875:2a75:1b94]) by smtp.gmail.com with ESMTPSA id h19-20020a63df53000000b003c14af50634sm307625pgj.76.2022.04.27.15.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 15:16:50 -0700 (PDT) Date: Wed, 27 Apr 2022 15:16:48 -0700 From: Minchan Kim To: Johannes Weiner Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Seth Jennings , Dan Streetman , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 4/5] mm: zswap: add basic meminfo and vmstat coverage Message-ID: References: <20220427160016.144237-1-hannes@cmpxchg.org> <20220427160016.144237-5-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0E40140064 X-Stat-Signature: zcx7frbr3j3rg4wpqmx7n4rkwxdzcnjs X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TXgc7SpR; spf=pass (imf04.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-HE-Tag: 1651097806-51779 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 27, 2022 at 05:20:29PM -0400, Johannes Weiner wrote: > On Wed, Apr 27, 2022 at 01:29:34PM -0700, Minchan Kim wrote: > > Hi Johannes, > > > > On Wed, Apr 27, 2022 at 12:00:15PM -0400, Johannes Weiner wrote: > > > Currently it requires poking at debugfs to figure out the size and > > > population of the zswap cache on a host. There are no counters for > > > reads and writes against the cache. As a result, it's difficult to > > > understand zswap behavior on production systems. > > > > > > Print zswap memory consumption and how many pages are zswapped out in > > > /proc/meminfo. Count zswapouts and zswapins in /proc/vmstat. > > > > > > Signed-off-by: Johannes Weiner > > > --- > > > fs/proc/meminfo.c | 7 +++++++ > > > include/linux/swap.h | 5 +++++ > > > include/linux/vm_event_item.h | 4 ++++ > > > mm/vmstat.c | 4 ++++ > > > mm/zswap.c | 13 ++++++------- > > > 5 files changed, 26 insertions(+), 7 deletions(-) > > > > > > diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c > > > index 6fa761c9cc78..6e89f0e2fd20 100644 > > > --- a/fs/proc/meminfo.c > > > +++ b/fs/proc/meminfo.c > > > @@ -86,6 +86,13 @@ static int meminfo_proc_show(struct seq_file *m, void *v) > > > > > > show_val_kb(m, "SwapTotal: ", i.totalswap); > > > show_val_kb(m, "SwapFree: ", i.freeswap); > > > +#ifdef CONFIG_ZSWAP > > > + seq_printf(m, "Zswap: %8lu kB\n", > > > + (unsigned long)(zswap_pool_total_size >> 10)); > > > + seq_printf(m, "Zswapped: %8lu kB\n", > > > + (unsigned long)atomic_read(&zswap_stored_pages) << > > > + (PAGE_SHIFT - 10)); > > > +#endif > > > > I agree it would be very handy to have the memory consumption in meminfo > > > > https://lore.kernel.org/all/YYwZXrL3Fu8%2FvLZw@google.com/ > > > > If we really go this Zswap only metric instead of general term > > "Compressed", I'd like to post maybe "Zram:" with same reason > > in this patchset. Do you think that's better idea instead of > > introducing general term like "Compressed:" or something else? > > I'm fine with changing it to Compressed. If somebody cares about a > more detailed breakdown, we can add Zswap, Zram subsets as needed. Thanks! Please consider ZSWPIN to rename more general term, too. > > From 8e9e2d6490b7082c41743fbdb9ffd2db4e3ce962 Mon Sep 17 00:00:00 2001 > From: Johannes Weiner > Date: Wed, 27 Apr 2022 17:15:15 -0400 > Subject: [PATCH] mm: zswap: add basic meminfo and vmstat coverage fix fix > > Signed-off-by: Johannes Weiner > --- > Documentation/filesystems/proc.rst | 7 ++++--- > fs/proc/meminfo.c | 2 +- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst > index 8b5a94cfa722..93edcf233464 100644 > --- a/Documentation/filesystems/proc.rst > +++ b/Documentation/filesystems/proc.rst > @@ -964,7 +964,7 @@ Example output. You may not have all of these fields. > Mlocked: 0 kB > SwapTotal: 0 kB > SwapFree: 0 kB > - Zswap: 1904 kB > + Compressed: 1904 kB > Zswapped: 7792 kB > Dirty: 12 kB > Writeback: 0 kB > @@ -1057,8 +1057,9 @@ SwapTotal > SwapFree > Memory which has been evicted from RAM, and is temporarily > on the disk > -Zswap > - Memory consumed by the zswap backend (compressed size) > +Compressed > + Memory consumed by compression backends, such as zswap > + (compressed size) > Zswapped > Amount of anonymous memory stored in zswap (original size) > Dirty > diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c > index 6e89f0e2fd20..554d6f230e67 100644 > --- a/fs/proc/meminfo.c > +++ b/fs/proc/meminfo.c > @@ -87,7 +87,7 @@ static int meminfo_proc_show(struct seq_file *m, void *v) > show_val_kb(m, "SwapTotal: ", i.totalswap); > show_val_kb(m, "SwapFree: ", i.freeswap); > #ifdef CONFIG_ZSWAP > - seq_printf(m, "Zswap: %8lu kB\n", > + seq_printf(m, "Compressed: %8lu kB\n", > (unsigned long)(zswap_pool_total_size >> 10)); > seq_printf(m, "Zswapped: %8lu kB\n", > (unsigned long)atomic_read(&zswap_stored_pages) << > -- > 2.35.3 >