From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB0B3C433EF for ; Fri, 13 May 2022 02:16:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A0796B0073; Thu, 12 May 2022 22:16:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 050966B0075; Thu, 12 May 2022 22:16:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E59956B0078; Thu, 12 May 2022 22:16:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D1FCC6B0073 for ; Thu, 12 May 2022 22:16:49 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9762431C2F for ; Fri, 13 May 2022 02:16:49 +0000 (UTC) X-FDA: 79459106538.21.7543E34 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id BF2461A00A9 for ; Fri, 13 May 2022 02:16:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sJnARy5TGz4NpCzf3IzEC2y86PKjT72on0U1COCcsiY=; b=La+cZ0PiXhgVAZf9GrKw0MGt13 A/qJeOL+7cPMG0h4QGK1tPteCkZSWazDjuWDc+XVBShe/Fe2p+nBRAyYYbK5QdHjE8KXIXze5GhX2 B/cmHpiiqGGA5iy96ptFNHXE+Aw38ny02uI0DCYoolfcplF11yeT0KmQ3bB4k+1w2+aFwMncosdXP kixjpgxm2+zAdWt+16cG++hFBwgMIjkwTEoBtGIkcyI/BDKkK5WFc6wxKY2ngUpoWzlIRCe37ZItb LLV2HWk10fW+59HOfQjLAr9z0ziBWLeIgCt22gKkEs/karD3ZSLdB7Itz/qgN+Hfqu49IdfKxrztw +got7fdg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1npKrE-006xVl-Lc; Fri, 13 May 2022 02:16:44 +0000 Date: Fri, 13 May 2022 03:16:44 +0100 From: Matthew Wilcox To: Yang Shi Cc: songmuchun@bytedance.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: rmap: use the correct parameter name for DEFINE_PAGE_VMA_WALK Message-ID: References: <20220512174551.81279-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220512174551.81279-1-shy828301@gmail.com> X-Stat-Signature: hzxfpcgwpbdazkges97aerc3fahs3enz X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BF2461A00A9 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=La+cZ0Pi; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspam-User: X-HE-Tag: 1652408199-893326 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 12, 2022 at 10:45:50AM -0700, Yang Shi wrote: > The parameter used by DEFINE_PAGE_VMA_WALK is _page not page, fix the > parameter name. It didn't cause any build error, it is probably because > the only caller is write_protect_page() from ksm.c, which pass in page. > > Fixes: 2aff7a4755be ("mm: Convert page_vma_mapped_walk to work on PFNs") > Signed-off-by: Yang Shi Oops. Reviewed-by: Matthew Wilcox (Oracle)