From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31B8BC433EF for ; Sat, 14 May 2022 00:26:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C2166B0073; Fri, 13 May 2022 20:26:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 770516B0075; Fri, 13 May 2022 20:26:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 611326B0078; Fri, 13 May 2022 20:26:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4D8276B0073 for ; Fri, 13 May 2022 20:26:11 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 13BBD31D4B for ; Sat, 14 May 2022 00:26:11 +0000 (UTC) X-FDA: 79462456542.08.712E3A9 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf01.hostedemail.com (Postfix) with ESMTP id 6F562400BB for ; Sat, 14 May 2022 00:25:57 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id gj17-20020a17090b109100b001d8b390f77bso12209391pjb.1 for ; Fri, 13 May 2022 17:26:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=y+n1fPZT1zdS+lAHwbtnaHu3tkmXjTbbjBa7vPYlABo=; b=O6V92x54nhsbw+iIsi5VHLqlpU/25LrFdzgZySWoN2Jrfjv/G3KftonhcTmUy8+al1 WFE6Q+tE0l2iBl25sRgpQbo9qhWdx+7LQtZft6V5k/h/7WOZNGlG35S3sPrBgkgQs9hp 3tvilCQ/lgFTZeOe6BIxP5p34eS2/nfLcGGBAlSpH5WKPoPzQueO4EBtjraJShnZ0Puj JNLJIYxMRvMTsSMvBtIVlwZO5+dGqyE0RJY+fJ51cHSBbBgakP4QrXQDkjvt2Ofq5IbP 6iFY+2AcNfxSZg9S+opPYsWSgCUOx9dixE2DVScTOtJ1u5b9h9LKzZ0w8nUmMAEI9TQQ QhnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=y+n1fPZT1zdS+lAHwbtnaHu3tkmXjTbbjBa7vPYlABo=; b=BolCriBWY7NmWKYRB1ybdj6gIKAC0gDtLiTV/CEsiP2qiVyxcHHWvEzqBOv08MN/CG IoSC/+0nxW3hmV2RW3qUiepFVh2OyyfjPfNwu5RurC4ZEPGBGC/V1EZfcTkcIGqY4KqB JSxRnlmygMXM61O35sx39svP0ZYPEoBgLOmacS4wLRRdeB+H27MBG8qTzXtVsRccDVij 6k0To/TD52WXAJAnwKiSe/VNSxeugMbZJVppsl/a0Y71WYXBqxs9XJSYl6wkQg8909b/ OLFbYVIyIZf8M0A9nIaAU3fT/4SsY55g7eDz4oF4hSZctgru75DnNwdl6PHZ87zkXHb6 bX3g== X-Gm-Message-State: AOAM532AGsJaAFOR7HzLmWAUezyeyrw33uCZcs6jZKu622TzwX2eECvR ms1+5tPsqsgFDaEBFLh4GUw= X-Google-Smtp-Source: ABdhPJyOeXl2fFGTzg0iG/6FpetLkDcmdjOHsoeI13uUcbQHA6nOkjFHKMo1BhP97JPHpR+hLyq8fg== X-Received: by 2002:a17:90b:3e8a:b0:1dc:9d7e:1e12 with SMTP id rj10-20020a17090b3e8a00b001dc9d7e1e12mr7400387pjb.58.1652487969532; Fri, 13 May 2022 17:26:09 -0700 (PDT) Received: from google.com ([2620:15c:211:201:1969:9b8a:5056:897b]) by smtp.gmail.com with ESMTPSA id n16-20020a6563d0000000b003c14af50607sm2160677pgv.31.2022.05.13.17.26.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 17:26:09 -0700 (PDT) Date: Fri, 13 May 2022 17:26:07 -0700 From: Minchan Kim To: John Hubbard Cc: Andrew Morton , Mike Kravetz , syzbot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, nathan@kernel.org, ndesaulniers@google.com, syzkaller-bugs@googlegroups.com, trix@redhat.com, Matthew Wilcox , Stephen Rothwell , David Hildenbrand Subject: Re: [syzbot] WARNING in follow_hugetlb_page Message-ID: References: <000000000000ef451a05dee0f2b1@google.com> <00000000000077377c05dee75f63@google.com> <20220513102617.c464c4f566052838e911a3ec@linux-foundation.org> <75f09063-d184-7d44-17a1-ed04be5eb953@oracle.com> <20220513161910.d1b73583cdb2e33562aa86e5@linux-foundation.org> <4809b134-a37a-50b8-4c25-44548bc1048f@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4809b134-a37a-50b8-4c25-44548bc1048f@nvidia.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6F562400BB X-Stat-Signature: 6k5drudiys4of3pcz68d7sqmo7qrykwx X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=O6V92x54; spf=pass (imf01.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-HE-Tag: 1652487957-188349 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 13, 2022 at 05:09:11PM -0700, John Hubbard wrote: > On 5/13/22 16:54, Minchan Kim wrote: > > > > I isolated this to Minchan Kim's "mm: fix is_pinnable_page against on cma > > > > page". Yes, the fat finger fix is in next-20220513. > > > > > > > > I don't have time to analyze right now, but can confirm that in the > > > > reproducer is_pinnable_page is returning false after this change when it > > > > previously returned true. > > > > > > OK, thanks, I dropped mm-fix-is_pinnable_page-against-on-cma-page.patch > > > > Seems like bug of the patch v5 due to change of this > > > > if (mt & (MIGRATE_CMA | MIGRATE_ISOLATE)) > > > > The migration type is not bit type so it shold be > > > > if (mt == MIGRATE_CMA || mt == MIGRATE_ISOLATE) > > > > Sorry for leading you astray by recommending the bitwise OR, Minchan. > I overlooked that point even though it was right in front of me. No worry, John. Anything else further can we get insight from the warning? For example, pin_user_pages going on against a hugetlb page which are concurrently running alloc_contig_range(it's exported function so anyone can call randomly) so alloc_contig_range changes pageblock type as MIGRATE_ISOLATE under us so the hit at the warning?